Skip to content

Commit 83498c4

Browse files
authored
Fixes #38230 - in host edit, unselecting media causes page freeze (#11320)
1 parent e2be2fb commit 83498c4

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

Diff for: app/assets/javascripts/katello/hosts/host_and_hostgroup_edit.js

+9-8
Original file line numberDiff line numberDiff line change
@@ -146,13 +146,13 @@ KT.hosts.onKatelloHostEditLoad = function(){
146146

147147
$.each(prefixes, function(index, prefix) {
148148
$.each(attributes, function(attrIndex, attribute) {
149-
$('body').on('change', '#' + prefix + '_' + attribute, function () {
149+
$('body').on('select2:select select2:unselecting', '#' + prefix + '_' + attribute, function () {
150150
KT.hosts.toggle_installation_medium();
151151
});
152152
});
153153
});
154154

155-
$('body').on('change', '#content_source_id', function () {
155+
$('body').on('select2:select select2:unselecting', '#content_source_id', function () {
156156
KT.hosts.contentSourceChanged();
157157
KT.hosts.toggle_installation_medium();
158158
});
@@ -266,14 +266,15 @@ KT.hosts.on_synced_content_dropdown_change = function() {
266266

267267
KT.hosts.set_install_media_bindings = function() {
268268
// reset the host medium id
269-
$("#host_medium_id").on("change", KT.hosts.on_install_media_dropdown_change);
270-
$("#s2id_host_medium_id").on("change", KT.hosts.on_install_media_dropdown_change);
271-
$("#hostgroup_medium_id").on("change", KT.hosts.on_install_media_dropdown_change);
272-
$("#s2id_hostgroup_medium_id").on("change", KT.hosts.on_install_media_dropdown_change);
269+
$("#host_medium_id").on("select2:select", KT.hosts.on_install_media_dropdown_change);
270+
$("#s2id_host_medium_id").on("select2:select", KT.hosts.on_install_media_dropdown_change);
271+
$("#hostgroup_medium_id").on("select2:select", KT.hosts.on_install_media_dropdown_change);
272+
$("#s2id_hostgroup_medium_id").on("select2:select", KT.hosts.on_install_media_dropdown_change);
273273
};
274-
275274
KT.hosts.set_synced_content_bindings = function() {
276-
KT.hosts.get_synced_content_dropdown().change(KT.hosts.on_synced_content_dropdown_change);
275+
KT.hosts
276+
.get_synced_content_dropdown()
277+
.on('select2:select', KT.hosts.on_synced_content_dropdown_change);
277278
};
278279

279280
KT.hosts.set_media_selection_bindings = function() {

0 commit comments

Comments
 (0)