Skip to content

Commit fa65150

Browse files
Removed "Basic Authentication" as per k0shk0sh#2927
Supporting article can be found [here](https://github.blog/2020-07-30-token-authentication-requirements-for-api-and-git-operations/#background)
1 parent 3897945 commit fa65150

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

Diff for: app/src/main/res/layouts/main_layouts/layout/login_chooser_layout.xml

+12-4
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,19 @@
138138
android:orientation="vertical"
139139
android:paddingBottom="@dimen/spacing_normal"
140140
android:paddingEnd="@dimen/spacing_xs_large"
141-
android:paddingStart="@dimen/spacing_xs_large"
142-
android:paddingTop="@dimen/spacing_normal">
141+
android:paddingStart="@dimen/spacing_xs_large">
142+
143+
<com.fastaccess.ui.widgets.FontTextView
144+
style="@style/TextAppearance.AppCompat.Small"
145+
android:layout_width="match_parent"
146+
android:layout_height="wrap_content"
147+
android:background="?selectableItemBackground"
148+
android:gravity="center_horizontal"
149+
android:text="@string/basic_authentication_report"
150+
android:textColor="@color/material_yellow_700"/>
143151

144152
<com.fastaccess.ui.widgets.FontTextView
153+
android:visibility="gone"
145154
android:id="@+id/basicAuth"
146155
style="@style/TextAppearance.AppCompat.Title"
147156
android:layout_width="match_parent"
@@ -160,8 +169,7 @@
160169
android:gravity="center"
161170
android:paddingBottom="@dimen/spacing_normal"
162171
android:paddingEnd="@dimen/spacing_large"
163-
android:paddingStart="@dimen/spacing_large"
164-
android:text="@string/or_character"/>
172+
android:paddingStart="@dimen/spacing_large"/>
165173

166174
<LinearLayout
167175
android:layout_width="match_parent"

Diff for: app/src/main/res/values/strings.xml

+1
Original file line numberDiff line numberDiff line change
@@ -604,4 +604,5 @@
604604
<string name="send_feedback">Send feedback</string>
605605
<string name="private_wiki_error_msg">Unfortunately we cannot access private repos wiki</string>
606606
<string name="file_history">File History</string>
607+
<string name="basic_authentication_report">Starting from November 13th, 2020, Github no longer accept login via account password aka \"Basic Authentication\".</string>
607608
</resources>

0 commit comments

Comments
 (0)