Skip to content

make globwalk an optional feature #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ctaggart opened this issue Jan 15, 2020 · 4 comments · May be fixed by #498
Open

make globwalk an optional feature #484

ctaggart opened this issue Jan 15, 2020 · 4 comments · May be fixed by #498
Labels
enhancement For next major version

Comments

@ctaggart
Copy link

Would it be possible to make globwalk an optional feature? I'm using templates from strings in a wasm app and it works great! I'd like to trim the dependencies and reduce the size os the wasm a bit. globwalk pulls in a whole tree of crates.
@Keats
Copy link
Owner

Keats commented Jan 15, 2020 •
edited
Loading

That would break Tera::new and be a breaking change if someone disabled the default features :/
It can be done for the next major version though

@ctaggart ctaggart linked a pull request Apr 12, 2020 that will close this issue
Open
@Keats Keats mentioned this issue Jul 25, 2020
Closed
@tonyhb
Copy link

tonyhb commented Mar 16, 2021 •
edited
Loading

For anyone else, for wasm I had to make globs and their tests optional, plus make rand optional vs being a builtin (tonyhb@9c9504e).

These are both done in this branch which is now just a lil behidn master - https://github.com/tonyhb/tera/tree/wasm)

@Keats
Copy link
Owner

Keats commented Mar 16, 2021

Note that the website use a WASM version of tera without removing glob

@tonyhb
Copy link

tonyhb commented Mar 16, 2021

I was compiling to WASI also 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement For next major version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make globs an optional feature ctaggart/tera
3 participants
@ctaggart @tonyhb @Keats