Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xr_linear.h XrQuaternionf_Multiply(r, a, b) returns product of b * a not a * b. #502

Open
jzulauf-lunarg opened this issue Sep 18, 2024 · 2 comments
Labels
synced to gitlab Synchronized to OpenXR internal GitLab

Comments

@jzulauf-lunarg
Copy link

jzulauf-lunarg commented Sep 18, 2024

Looking at the signs of the cross terms they reflect the commuted order of multiplication.

As there doesn't appear to be either unit test, nor documentation it's not clear if this is intended behavior and simply undocumented, or whether it's simply an error (or something I don't understand ).

Also, as this function is called from several other locations within the header, it's not clear as to their correctness.

@jzulauf-lunarg
Copy link
Author

@rpavlik -- this git blames to you. Not sure about ownership.

@rpavlik-bot
Copy link
Collaborator

An issue (number 2372) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2372 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

No branches or pull requests

2 participants