errors when compiling with clang

[simeonschaub]

(Cross-)Compiling with clang 18, I get the following errors: errors.log.

The build passes if I add -DCMAKE_CXX_FLAGS="-Wno-error=enum-constexpr-conversion -include vector", so seems like there are a couple of missing #include <vector>s and some missing explicit casts.

[svenvh]

Thanks for the report! I can see some includes are definitely missing, so I've opened #3413.

Keeping this open to make sure we address the conversion warnings too.