Reject invalid onlyIssues CLI usage (#239)

KhronosGroup · Oct 18, 2024 · 6033ce9 · 6033ce9
1 parent 1c107cd
commit 6033ce9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/lib/cmd_line.dart b/lib/cmd_line.dart
@@ -90,7 +90,7 @@ ValidationOptions _getValidationOptionsFromYaml(String fileName) {
   const kOverride = 'override';
 
   void abort(Object e) {
-    stderr.write(e);
+    stderr.writeln(e);
     exit(kErrorCode);
   }
 
@@ -135,7 +135,7 @@ ValidationOptions _getValidationOptionsFromYaml(String fileName) {
         }
       }, growable: false);
     } else if (yamlIgnoredIssues != null) {
-      abort("$kYamlError 'ignored' must be a sequence.");
+      abort("$kYamlError '$kIgnore' must be a sequence.");
     }
 
     final Object yamlOnlyIssues = yaml[kOnly];
@@ -150,7 +150,12 @@ ValidationOptions _getValidationOptionsFromYaml(String fileName) {
         }
       }, growable: false);
     } else if (yamlOnlyIssues != null) {
-      abort("$kYamlError 'only' must be a sequence.");
+      abort("$kYamlError '$kOnly' must be a sequence.");
+    }
+
+    if (onlyIssues != null && ignoredIssues != null) {
+      abort("$kYamlError option '$kOnly' cannot be used "
+          "along with option '$kIgnore'.");
     }
 
     final Object yamlSeveritiesMap = yaml[kOverride];

diff --git a/node/gltf_validator.dart b/node/gltf_validator.dart
@@ -229,8 +229,8 @@ Context _getContextFromOptions(_JSValidationOptions options) {
     }
 
     if (options.onlyIssues != null && options.ignoredIssues != null) {
-      throw ArgumentError(
-          'options.onlyIssues cannot be used along with options.ignoredIssues.');
+      throw ArgumentError('options.onlyIssues cannot be used '
+          'along with options.ignoredIssues.');
     }
 
     if (options.onlyIssues != null) {