Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧Update random service #46

Closed
1 task done
CalvinWilkinson opened this issue Oct 9, 2023 · 0 comments · Fixed by #82
Closed
1 task done

🚧Update random service #46

CalvinWilkinson opened this issue Oct 9, 2023 · 0 comments · Fixed by #82
Assignees
@CalvinWilkinson
Labels
🧨breaking-changes Feature/changes contains breaking changes cicd CI/CD related work only high-priority High Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Milestone
v1.0.0-preview.3

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Oct 9, 2023 •
edited
Loading

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Update the TrueRandomizerService service implementation. The internal use of the RNGCryptoServiceProvider has been deprecated by microsoft.

Use the RandomNumberGenerator instead.

More info about the deprecation can be found here.

With dotnet 8, some new randomization changes and improvements have been made.
Go here for more information.

Acceptance Criteria
Beta Give feedback

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct milestone (if applicable).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction labels Oct 9, 2023
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Oct 9, 2023
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.3 milestone Oct 9, 2023
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team Jun 8, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Jun 8, 2024
CalvinWilkinson added a commit that referenced this issue Jun 8, 2024
@CalvinWilkinson
Start work for issue #46
091f172
@CalvinWilkinson CalvinWilkinson mentioned this issue Jun 8, 2024
Merged
1 task
@CalvinWilkinson CalvinWilkinson added 🧨breaking-changes Feature/changes contains breaking changes cicd CI/CD related work only labels Jun 8, 2024
CalvinWilkinson added a commit that referenced this issue Jun 8, 2024
@CalvinWilkinson
🚧Update random service (#82)
07fcfef 
* Start work for issue #46

* chore!: remove the PseudoRandomizerService from the code base

* refactor!: change the name of the built in randomizer service

* refactor: swap out the randomization method used

* chore!: remove the IDisposable interface and it's implementations

* test: update random service tests

* chore: add perf test project to test random service

* docs: create base line perf test results

* ide: add word to dictionary

* chore: disable warnings and suggestions

* ci: add perf project to build status check

* ci: fix permission issue with sync bot workflow
@github-project-automation github-project-automation bot moved this from 🏗️In Development to ✅Done in KD-Team Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CalvinWilkinson CalvinWilkinson

Labels
🧨breaking-changes Feature/changes contains breaking changes cicd CI/CD related work only high-priority High Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
KD-Team
Archived in project
Milestone
v1.0.0-preview.3
Development

Successfully merging a pull request may close this issue.

🚧Update random service KinsonDigital/Plazma
1 participant
@CalvinWilkinson