Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Remove deno scripts and config #1043

Conversation

bmonish
Copy link
Contributor

@bmonish bmonish commented Oct 12, 2024

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #1042

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

[!Note] You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.39 milestone Oct 12, 2024
@CalvinWilkinson CalvinWilkinson added tech-debt Code refactoring or cleanup / tech debt reduction low-priority Low Priority 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! labels Oct 12, 2024
@bmonish
Copy link
Contributor Author

bmonish commented Oct 12, 2024

@CalvinWilkinson Can you please explain how I can run the tests locally?

@KinsonDigitalAdmin
Copy link
Contributor

KinsonDigitalAdmin commented Oct 12, 2024

@CalvinWilkinson Can you please explain how I can run the tests locally?

Sure thing. Which IDE are you using?

Note

The unit tests have passed. The unit test status check results for this pull request show this.
image

I would be happy to help you learn how to run those tests. There are many ways to run tests, but it depends on what tools you are using and your experience, which is why I ask about what IDE you are using.

@KinsonDigitalAdmin
Copy link
Contributor

@bmonish

Just a quick tip. You do not have to use the issue number in the git commit messages. 😊

It's fine to use all lowercase and conventional commits. I do not try to force outside contributors to use conventional commits, but it seems like you are going that route,, so I thought you would be interested.

@KinsonDigitalAdmin
Copy link
Contributor

@bmonish

Just a quick note. I have made a couple of commits on your branch on my behalf so I can introduce a workflow change as well as force the status checks to be executed.

@CalvinWilkinson CalvinWilkinson merged commit 7f43352 into KinsonDigital:preview Oct 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! low-priority Low Priority tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Remove deno scripts and config
3 participants