Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Improve logging #47

Merged
merged 4 commits into from
Aug 29, 2024
Merged

🚧Improve logging #47

merged 4 commits into from
Aug 29, 2024

Conversation

CalvinWilkinson
Copy link
Member

@CalvinWilkinson CalvinWilkinson commented Aug 29, 2024

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #44

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.5 milestone Aug 29, 2024
@CalvinWilkinson CalvinWilkinson changed the title new pr 🚧Improve logging Aug 29, 2024
@CalvinWilkinson CalvinWilkinson added preview Done while in preview 🐛bug Something isn't working labels Aug 29, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Aug 29, 2024
@CalvinWilkinson
Copy link
Member Author

Note

Added the following 💎enhancement An improvement on something 's

  1. Improved the error log message when a file version key with value cannot be found.

@CalvinWilkinson
Copy link
Member Author

Note

Fixed the following 🐛bug Something isn't working 's

  1. Fixed a bug where when the error logs are incorrect when a GitHub user name is invalid.

@CalvinWilkinson CalvinWilkinson added 💎enhancement An improvement on something ♻️cicd CI/CD related work only labels Aug 29, 2024
@CalvinWilkinson
Copy link
Member Author

Note

Made the following ♻️cicd CI/CD related work only changes

  1. Fixed an issue with the if logic for the jobs in the sync-pr-to-issue.yml workflow, preventing regular feature branch PRs from running issues to PR syncs.

@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review August 29, 2024 15:30
@CalvinWilkinson CalvinWilkinson merged commit 132079a into preview Aug 29, 2024
5 of 6 checks passed
@CalvinWilkinson CalvinWilkinson deleted the feature/44-improve-logging branch August 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working ♻️cicd CI/CD related work only 💎enhancement An improvement on something preview Done while in preview
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Improve logging
2 participants