Fix #176.

Properly parse items that contain a '=' and don't lose metadata hanging off of them.

Author: KirillOsenkov

src/StructuredLogger.Tests/ItemGroupParserTests.cs

@@ -15,5 +15,33 @@ public void AddItemWithMultilineMetadata()
                 AdditionalDependencies=kernel32.lib;user32.lib;
                 ;", MessageProcessor.OutputItemsMessagePrefix, new StringCache());
         }
+
+        /// <summary>
+        /// https://github.com/KirillOsenkov/MSBuildStructuredLog/issues/176
+        /// </summary>
+        [Fact]
+        public void ParseSuggestedBindingRedirectsMetadata()
+        {
+            var parameter = ItemGroupParser.ParsePropertyOrItemList(@"Output Item(s): 
+    SuggestedBindingRedirects=
+        Microsoft.Build, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
+                MaxVersion=15.1.0.0
+        Microsoft.VisualStudio.Validation, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
+                MaxVersion=15.3.0.0",
+                MessageProcessor.OutputItemsMessagePrefix, new StringCache()) as Parameter;
+            Assert.True(parameter != null);
+            Assert.True(parameter.Children.Count == 2);
+
+            var item = parameter.FirstChild as Item;
+            Assert.True(item != null);
+
+            var metadata = item.FirstChild as Metadata;
+            Assert.True(metadata != null);
+
+            Assert.Equal("SuggestedBindingRedirects", parameter.Name);
+            Assert.Equal("Microsoft.Build, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a", item.Text);
+            Assert.Equal("MaxVersion", metadata.Name);
+            Assert.Equal("15.1.0.0", metadata.Value);
+        }
     }
 }

src/StructuredLogger/Construction/ItemGroupParser.cs

@@ -99,6 +99,23 @@ public static object ParsePropertyOrItemList(string message, string prefix, Stri
                         }
                         break;
                     case 16:
+                        if (currentItem == null && currentProperty != null)
+                        {
+                            // we incorrectly interpreted the previous line as Property, not Item (because it had '=')
+                            // and so we created a property out of name/value.
+                            // Fix this by turning it into an Item.
+                            if (parameter.LastChild == currentProperty)
+                            {
+                                currentItem = new Item
+                                {
+                                    Text = currentProperty.Name + "=" + currentProperty.Value
+                                };
+                                parameter.Children.RemoveAt(parameter.Children.Count - 1);
+                                currentProperty = null;
+                                parameter.AddChild(currentItem);
+                            }
+                        }
+
                         if (currentItem != null)
                         {
                             var span16 = lineSpan.Skip(16);

src/StructuredLogger/ObjectModel/TreeNode.cs

@@ -267,6 +267,32 @@ public virtual T FindLastChild<T>()
             return default(T);
         }
 
+        public object FirstChild
+        {
+            get
+            {
+                if (HasChildren)
+                {
+                    return Children[0];
+                }
+
+                return null;
+            }
+        }
+
+        public object LastChild
+        {
+            get
+            {
+                if (HasChildren)
+                {
+                    return Children[Children.Count - 1];
+                }
+
+                return null;
+            }
+        }
+
         public virtual T FindLastDescendant<T>(Predicate<T> predicate = null)
         {
             if (HasChildren)