Improve TaskItem implementation (for metadata).

KirillOsenkov · KirillOsenkov · commit 2f325dca78e9 · 2018-08-17T20:12:13.000-07:00
diff --git a/src/StructuredLogger/ObjectModel/TaskItem.cs b/src/StructuredLogger/ObjectModel/TaskItem.cs
@@ -35,13 +35,16 @@ public IDictionary CloneCustomMetadataEscaped()
 
         public void CopyMetadataTo(ITaskItem destinationItem)
         {
-            throw new NotImplementedException();
+            foreach (var kvp in Metadata)
+            {
+                destinationItem.SetMetadata(kvp.Key, kvp.Value);
+            }
         }
 
         public string GetMetadata(string metadataName)
         {
             Metadata.TryGetValue(metadataName, out var result);
-            return result;
+            return result ?? "";
         }
 
         public string GetMetadataValueEscaped(string metadataName)

Original file line number	Diff line number	Diff line change
`@@ -35,13 +35,16 @@ public IDictionary CloneCustomMetadataEscaped()`
`35`	`35`
`36`	`36`	`public void CopyMetadataTo(ITaskItem destinationItem)`
`37`	`37`	`{`
`38`		`- throw new NotImplementedException();`
	`38`	`+ foreach (var kvp in Metadata)`
	`39`	`+ {`
	`40`	`+ destinationItem.SetMetadata(kvp.Key, kvp.Value);`
	`41`	`+ }`
`39`	`42`	`}`
`40`	`43`
`41`	`44`	`public string GetMetadata(string metadataName)`
`42`	`45`	`{`
`43`	`46`	`Metadata.TryGetValue(metadataName, out var result);`
`44`		`- return result;`
	`47`	`+ return result ?? "";`
`45`	`48`	`}`
`46`	`49`
`47`	`50`	`public string GetMetadataValueEscaped(string metadataName)`