Display WHICH source item has Private=false.

Author: KirillOsenkov

src/StructuredLogViewer/Analyzers/ResolveAssemblyReferenceAnalyzer/ResolveAssemblyReferenceAnalyzer.cs

@@ -65,10 +65,14 @@ public void AnalyzeResolveAssemblyReference(Task rar)
                         }
                     }
 
+                    var thisReferenceName = ParseReferenceName(reference.Name);
+
                     if (reference.Name.StartsWith("Dependency ") || reference.Name.StartsWith("Unified Dependency "))
                     {
                         bool foundNotCopyLocalBecauseMetadata = false;
                         var requiredBy = new List<Item>();
+                        Item notCopyLocalMessage = null;
+
                         foreach (var message in reference.Children.OfType<Item>())
                         {
                             string text = message.Text;
@@ -79,6 +83,7 @@ public void AnalyzeResolveAssemblyReference(Task rar)
                             else if (text == @"This reference is not ""CopyLocal"" because at least one source item had ""Private"" set to ""false"" and no source items had ""Private"" set to ""true"".")
                             {
                                 foundNotCopyLocalBecauseMetadata = true;
+                                notCopyLocalMessage = message;
                             }
                         }
 
@@ -105,6 +110,10 @@ public void AnalyzeResolveAssemblyReference(Task rar)
                                             if (metadata.Name == "Private")
                                             {
                                                 sourceItem.AddChild(new Metadata() { Name = metadata.Name, Value = metadata.Value });
+                                                if (notCopyLocalMessage != null)
+                                                {
+                                                    notCopyLocalMessage.AddChild(new Message { Text = $"{foundSourceItem.ToString()} has {metadata.Name} set to {metadata.Value}" });
+                                                }
                                             }
                                         }
                                     }
@@ -142,6 +151,30 @@ public void AnalyzeResolveAssemblyReference(Task rar)
             }
         }
 
+        private string ParseReferenceName(string name)
+        {
+            var quote = name.IndexOf('"');
+            if (quote == -1)
+            {
+                return null;
+            }
+
+            name = name.Substring(quote + 1);
+            var comma = name.IndexOf(',');
+            if (comma == -1)
+            {
+                quote = name.IndexOf('"');
+                if (quote == -1)
+                {
+                    return null;
+                }
+
+                return name.Substring(0, quote);
+            }
+
+            return name.Substring(0, comma);
+        }
+
         public void AppendFinalReport(Build build)
         {
             if (UsedLocations.Any())