Skip to content

Commit d72b8bf

Browse files
committed
Revert breaking change in the reader for ProjectEvaluationFinished
I don't understand this, so we'll need to patch it later. For now revert it to what it was to read existing binlogs properly.
1 parent 7901b7f commit d72b8bf

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/StructuredLogger/BinaryLogger/BuildEventArgsReader.cs

+3-4
Original file line numberDiff line numberDiff line change
@@ -723,12 +723,11 @@ private BuildEventArgs ReadProjectEvaluationFinishedEventArgs()
723723

724724
if (_fileFormatVersion >= 12)
725725
{
726-
if (_fileFormatVersion < BinaryLogger.ForwardCompatibilityMinimalVersion)
726+
IEnumerable globalProperties = null;
727+
if (ReadBoolean())
727728
{
728-
// Throw away, but need to advance past it
729-
ReadBoolean();
729+
globalProperties = ReadStringDictionary();
730730
}
731-
IEnumerable? globalProperties = ReadStringDictionary();
732731

733732
var propertyList = ReadPropertyList();
734733
var itemList = ReadProjectItems();

0 commit comments

Comments
 (0)