Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicks on value tuple items are broken [source.dot.net] #221

Open
hankovich opened this issue Nov 8, 2022 · 4 comments
Open

Clicks on value tuple items are broken [source.dot.net] #221

hankovich opened this issue Nov 8, 2022 · 4 comments

Comments

@hankovich
Copy link

This page, for example

if (_connections.TryGetValue(id, out var pair)) // _connections is ConcurrentDictionary<string, (HttpConnectionContext Connection, ValueStopwatch Timer)>
{
    connection = pair.[Connection](https://source.dot.net/System.Private.CoreLib/A.html#22818ac7b7f5b2ab);
    return true;
}

Clicking on .Connection; redirects to this page, which says Don't use this page directly, pass #symbolId to get redirected..

I've tried a couple of ValueTuples with different arity, all of them don't work.

@alexperovich

@alexperovich
Copy link
Contributor

I'm not sure if there is any useful location this can go to. Would you want it to go to ValueTuple<T1, T2>.Item1?

@hankovich
Copy link
Author

I think at least it should not point to an unexisting location. Item1 feels like a good alternative.

@KirillOsenkov
Copy link
Owner

Should it go to the type of Item1 instead? Would be more useful I think.

@KirillOsenkov
Copy link
Owner

This is roughly the place that is looking at the current identifier, sees it's a reference to a symbol, sees the symbol is a field and does the processing:

I think roughly in this area we could add some could that would detect that we're looking at a value tuple field, get its type, and create a hyperlink to that type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants