-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federation doesn't work against source.dot.net #233
Comments
@mconnew |
That would satisfy one use case. What I have been planning is to have two sites available, one for the current GA release, and one for the current in-development release (updated on every merge as we don't have a lot of merges). Our current 1.x release supports netstandard2.0 and runs on .NET Framework. At some point we're going to drop netstandard2.0 support and have a minimum requirement of the latest .NET LTS release. When that happens, our latest 1.x version will be a perpetually supported version so we would have 3 sites available. The latest GA release, the latest 1.x release, and the dev version. If there's an opportunity to have our code published to a central site, then the latest GA release would be the one we would want published. We'll work out the hosting of the dev/1.x version ourselves. A bit of feedback with you developing the successor, currently source.dot.net hosts the source as is built for Linux. I use source.dot.net as a replacement for having to clone the repo and load it in VS as navigating the source is really easy. When trying to explore the source code on source.dot.net, it would be nice to be able to choose different compile time defines, e.g. building for Linux vs Windows. When I was implementing NetNamedPipe and I needed to understand the behavior of the runtime named pipe classes, I had to browse the source code on github.com as the implementation is a lot different on Linux (and NetNamedPipe is a Windows only feature). |
I'm trying to set up a source browser for the CoreWCF project and would like all the links to the .NET types to go to https://source.dot.net. I used the following command line to generate the SourceBrowser site:
The indexing of the CoreWCF solution worked, but the offsite links are incorrect. When viewing TextMessageEncoder, one of the fields is of type System.Text.Encoding. The link generated for the type is https://source.dot.net/netstandard/A.html#3b6090c501893c25 but the link should be https://source.dot.net/System.Private.CoreLib/A.html#3b6090c501893c25. I presume this is because the CoreWCF libraries are compiled against netstandard2.0 and the name of the referenced assembly is
netstandard
.Is there a way to fix these federated links to go to the right place?
The text was updated successfully, but these errors were encountered: