-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tv show episode doesn't get an overlay score #2291
Comments
Your log is also saying you should update to 2.1.0
|
Doing the plex dance fixed the issue. I do however think that the cache issue is worth being investigated. It appears that I'm not the only one with this issue. @antwanchild said yesterday to me in discord that he has had this issue in the past before as well as I have had this issue a couple of times. |
I had the issue, not related specifically to an episode, but an issue where renaming the cache fixed what i was having issue with |
The problem with that fix is that renaming the cache forces a new cache to be built which takes way too much time. I don't consider that to be an optimal solution. I rather believe that investigation the cause of the cache issue is worth pursuing. |
This is the reason you were asked for logs of when it was added Kometa and when Kometa updated the rating and stated it applied an overlay when it actually didn't |
When Kometa applies an overlay, it saves a record of all aspects of the overlay in the cache. For example:
On subsequent runs, if that record has not changed, Kometa figures that the current overlay matches the one it's about to apply, so "No Overlay Update Needed" If you delete the cache, nothing matches so everything gets updated. For some reason, Kometa thought that the thing already had the overlays it was supposed to have. Perhaps there was some inconsistency, perhaps the "what overlay did I apply" is incomplete [I think only position changes aren't captured for some overlays, for example]. |
For more background, the episode was added to plex on october the 16th. The problematic episode was the 8th episode of the second season of Tell me Lies Hope this helps! |
I have more recent logs if those are neede |
Seems like there's some logic error in there. Once it gets an overlay future changes in the rating don't apply a new overlay.
|
What's in |
|
So you are confirming this is indeed a bug and that it can be fixed in a future release? |
I'm just commenting on what I'm seeing in your logs. That's data from your log files. I haven't reproduced it, though those tests are ongoing. |
It looks like there's an issue going to or from a null rating: |
Interesting. So it is looking like an interesting bug. I'm happy to hear that, I thought I was crazy cause it was happening to me and not everyone else |
Is there anything else you need from my side? More logs or something? Also, which is the next step for this? Will this be treated as a bug? @chazlarson |
Nothing else needed here. Future action is dependent on the author reviewing it. |
Should I tag him? |
No need, this issue is assigned to him. |
This is ready to be tested using the If testing works as expected we will push this into nightly. |
Excellent! Once I see it happening again, I will try it out! Big thank you! |
@YozoraXCII @chazlarson @antwanchild @meisnate12 I think may still be happening: |
Neither |
@rafapirotto That log contains no references to a show called "Bad Sisters". |
Let me correct that |
There you go @YozoraXCII @chazlarson |
Just to double check, were you able to see the updated link? If you need anything else like more logs just ask! |
Got the link but I can't personally look until tomorrow I tested earlier and confirmed the issue of null ratings appears to be fixed in nightly. Are you running the latest nightly build? If yes, try deleting your config.cache and doing another run. If that doesn't work, maybe try removing your overlays and letting it start from scratch |
Hey! I am using the latest nightly build. I don't think delete the cache or removing the overlays is the solution. This shouldn't happen in the first place. This has been happening to me lately, before and after the fix. Also, I specifically ran another run and I had the results you are seeing. I am running docker with the latest nightly build |
All the log shows is that Kometa thinks the ratings are up to date and Kometa sees no reason to update the overlays. Perhaps running in trace mode would provide more specifics about why exactly Kometa doesn't think it has to update the ratings. Perhaps hiding the cache would show if there's a cache issue that needs to be addressed. Perhaps forcing a reapply of the overlays [or removing and reapplying] would clear whatever is telling Kometa that it doesn't need to. These are tests you can run to try to reproduce a problem which we cannot, in an effort to try to determine the cause. All we can see form that log is:
The log doesn't show why Kometa may think that; some of these other tests may. |
Hey! Thanks for the reply. As I said before, I have tried both hiding/deleting the cache and force the overlays in the past and both solve my problem. The thing is that I need to be manually checking each time to see if overlays are missing and then manually either delete the cache and wait for that run to run (which in my experience takes longer than a normal run because of course it does not have any cached stuff). Or, manually run a reapply overlay. My gut tells me it is something either cache related or related to the logic behind how kometa decides if something needs an update. I have yet to find the exact way to recreate this issue. What I know is that is happens with episodes that have aired recently. Like I download an episode and it doesn’t yet have a rating in imdb, and it gets stuck like that even after imdb gets a rating. I can run trace mode and provide the logs, but if I reapply overlays or delete/hide the cache I will solve my problem but I will also reset the current conditions that depict my problem and I would have to wait for another episode or tv show to air and also the imdb rating would have to be missing. This all is a bit time consuming 😓 |
The recent-episode situation is exactly what led to this initially and is the situation which is believed to have been fixed. Coming up with a repeatable recipe is a requirement for fixing whatever may still remain. |
Perhaps uploading your cache file would be a thing that would be useful. |
I know that was the case, but the fact that I am running the nightly build and this still happens show that there is still something wrong. |
Sure! I will get that tomorrow! |
@chazlarson here is my cache |
I'm also running with trace mode, will provide the logs soon |
Here is the logs with trace enabled: CC: @chazlarson |
Version Number
Version: 2.0.2 (Docker: master)
What branch are you on?
master
Describe the Bug
For some reason the last episode of the second season of "Tell me lies" doesn't get an imdb score overlay. I've noticed that the other episodes get updated but this last one has never got a score overlay.
I've checked the imdb page and it has always had a score
Relevant Collection/Overlay/Playlist Definition
Logs
https://gist.github.com/rafapirotto/e2b37800001e370a7cf1423224e0416f
The text was updated successfully, but these errors were encountered: