add linting

Author: ChrisSchinnerl

.golangci.yml

@@ -38,7 +38,6 @@ linters-settings:
         json: goCamel
         yaml: goCamel
 
-
   gocritic:
     # Which checks should be enabled; can't be combined with 'disabled-checks';
     # See https://go-critic.github.io/overview#checks-overview
@@ -112,6 +111,8 @@ linters-settings:
         disabled: false
       - name: unnecessary-stmt
         disabled: false
+      - name: unused-parameter
+        disabled: false
       - name: unreachable-code
         disabled: false
       - name: package-comments

rhp/v4/quic/quic.go

@@ -54,7 +54,7 @@ type (
 // WithTLSConfig is a QUICTransportOption that sets the TLSConfig
 // for the QUIC connection.
 func WithTLSConfig(fn func(*tls.Config)) ClientOption {
-	return func(qc *quic.Config, tc *tls.Config) {
+	return func(_ *quic.Config, tc *tls.Config) {
 		fn(tc)
 	}
 }

rhp/v4/rpc_test.go

@@ -140,7 +140,7 @@ func startTestNode(tb testing.TB, n *consensus.Network, genesis types.Block) (*c
 		}
 	}()
 
-	stop := cm.OnReorg(func(index types.ChainIndex) {
+	stop := cm.OnReorg(func(_ types.ChainIndex) {
 		select {
 		case reorgCh <- struct{}{}:
 		default:

rhp/v4/siamux/siamux.go

@@ -66,12 +66,16 @@ func Dial(ctx context.Context, addr string, peerKey types.PublicKey) (rhp4.Trans
 	if err != nil {
 		return nil, fmt.Errorf("failed to connect to %q: %w", addr, err)
 	}
-
-	return Upgrade(ctx, conn, peerKey)
+	if deadline, ok := ctx.Deadline(); ok {
+		if err := conn.SetDeadline(deadline); err != nil {
+			return nil, fmt.Errorf("failed to set deadline: %w", err)
+		}
+	}
+	return Upgrade(conn, peerKey)
 }
 
 // Upgrade upgrades an existing connection to use the SiaMux transport.
-func Upgrade(ctx context.Context, conn net.Conn, peerKey types.PublicKey) (rhp4.TransportClient, error) {
+func Upgrade(conn net.Conn, peerKey types.PublicKey) (rhp4.TransportClient, error) {
 	m, err := mux.Dial(conn, peerKey[:])
 	if err != nil {
 		return nil, fmt.Errorf("failed to establish siamux connection: %w", err)

testutil/host.go

@@ -76,7 +76,7 @@ func (es *EphemeralSectorStore) ReadSector(root types.Hash256) (*[proto4.SectorS
 }
 
 // StoreSector stores a sector in the EphemeralSectorStore.
-func (es *EphemeralSectorStore) StoreSector(root types.Hash256, sector *[proto4.SectorSize]byte, expiration uint64) error {
+func (es *EphemeralSectorStore) StoreSector(root types.Hash256, sector *[proto4.SectorSize]byte, _ uint64) error {
 	es.mu.Lock()
 	defer es.mu.Unlock()
 	es.sectors[root] = sector

testutil/syncer.go

@@ -61,12 +61,12 @@ func (ps *EphemeralPeerStore) UpdatePeerInfo(addr string, fn func(*syncer.PeerIn
 
 // Ban temporarily bans one or more IPs. The addr should either be a single
 // IP with port (e.g. 1.2.3.4:5678) or a CIDR subnet (e.g. 1.2.3.4/16).
-func (ps *EphemeralPeerStore) Ban(addr string, duration time.Duration, reason string) error {
+func (ps *EphemeralPeerStore) Ban(_ string, _ time.Duration, _ string) error {
 	return nil
 }
 
 // Banned returns false
-func (ps *EphemeralPeerStore) Banned(addr string) (bool, error) { return false, nil }
+func (ps *EphemeralPeerStore) Banned(_ string) (bool, error) { return false, nil }
 
 var _ syncer.PeerStore = (*EphemeralPeerStore)(nil)
 

testutil/wallet.go

@@ -44,7 +44,7 @@ func (et *ephemeralWalletUpdateTxn) UpdateWalletSiacoinElementProofs(pu wallet.P
 	return nil
 }
 
-func (et *ephemeralWalletUpdateTxn) WalletApplyIndex(index types.ChainIndex, created, spent []types.SiacoinElement, events []wallet.Event, timestamp time.Time) error {
+func (et *ephemeralWalletUpdateTxn) WalletApplyIndex(index types.ChainIndex, created, spent []types.SiacoinElement, events []wallet.Event, _ time.Time) error {
 	for _, se := range spent {
 		if _, ok := et.store.utxos[types.SiacoinOutputID(se.ID)]; !ok {
 			panic(fmt.Sprintf("siacoin element %q does not exist", se.ID))
@@ -65,7 +65,7 @@ func (et *ephemeralWalletUpdateTxn) WalletApplyIndex(index types.ChainIndex, cre
 	return nil
 }
 
-func (et *ephemeralWalletUpdateTxn) WalletRevertIndex(index types.ChainIndex, removed, unspent []types.SiacoinElement, timestamp time.Time) error {
+func (et *ephemeralWalletUpdateTxn) WalletRevertIndex(index types.ChainIndex, removed, unspent []types.SiacoinElement, _ time.Time) error {
 	// remove any events that were added in the reverted block
 	filtered := et.store.events[:0]
 	for i := range et.store.events {