Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(certificates):fix missing info when fields was absent #14032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(certificates):fix missing info when fields was absent #14032

wants to merge 1 commit into from
+117 −0

Conversation

lhanjian
Copy link
Contributor

@lhanjian lhanjian commented Dec 18, 2024 •
edited
Loading

Summary

  • More info of flattened_erros when field was absent.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix FTI-6351

@github-actions github-actions bot added core/db cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 18, 2024
@lhanjian lhanjian requested review from outsinre and flrgh December 18, 2024 04:02
lhanjian
lhanjian commented Dec 18, 2024
View reviewed changes
spec/02-integration/04-admin_api/15-off_spec.lua
assert.equals("snis:required field missing:certificate", entities.flattened_errors[1].errors[1].message)
end)

it("flatten_errors1 when conflicting inputs", function()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only add a test, not about errors.lua change

@lhanjian lhanjian force-pushed the fix/missing-snis-missing-flattend-errors branch from 27a3f33 to ab01f6c Compare December 19, 2024 03:42
chobits
chobits requested changes Dec 19, 2024
View reviewed changes
kong/db/errors.lua Show resolved Hide resolved
@lhanjian lhanjian force-pushed the fix/missing-snis-missing-flattend-errors branch from f66684b to da087f8 Compare December 20, 2024 07:48
flrgh
flrgh reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge yet. I have some changes to suggest but have not had time to fully review.

@lhanjian
Copy link
Contributor Author

lhanjian commented Jan 8, 2025

@flrgh hi, do you have more comments?

@flrgh
Copy link
Contributor

flrgh commented Jan 11, 2025 •
edited
Loading

Sorry for blocking this for such a long while. Now that I am caught up on the context, I don't think this is needed. I don't see the error string change (entity_type..":"..field_err_t..":"..ref.field) as particularly helpful in the general sense, and--more importantly--the error that is being used as a test case in this changeset is caused by a bug that will be fixed by #14082, so it will actually be unreachable once that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flrgh flrgh flrgh left review comments

@outsinre outsinre outsinre approved these changes

@chobits chobits chobits approved these changes

Assignees

@lhanjian lhanjian

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhanjian @flrgh @chobits @outsinre