Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples/ tests #6816

Open
1 task
pmalek opened this issue Dec 11, 2024 · 0 comments
Open
1 task

Add examples/ tests #6816

pmalek opened this issue Dec 11, 2024 · 0 comments

Comments

@pmalek
Copy link
Member

pmalek commented Dec 11, 2024

Problem statement

Currently this repo contains example manifests in examples/ dir. These manifests are not tested at any point.

This should change so that they are continuously tested in CI.

This issue tracks this.

Proposed solution

We could reuse KGO's approach in Makefile and from its CI.

Alternatively we could use a solution like https://github.com/kubernetes-sigs/kubectl-validate to just validate the examples against the CRD schemas

Acceptance criteria

  • Examples from examples/ directory are tested in CI
@pmalek pmalek added this to the KIC v3.5.x milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant