Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate go-kong 0.61.0 and gdr 1.17.0 breaking changes #6823

Open
pmalek opened this issue Dec 12, 2024 · 3 comments
Open

Investigate go-kong 0.61.0 and gdr 1.17.0 breaking changes #6823

pmalek opened this issue Dec 12, 2024 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@pmalek
Copy link
Member

pmalek commented Dec 12, 2024

Problem statement

During the release of KIC 3.4 and Gateway 3.9 we've discovered that enterprise-postgres integration test suite fails when running KIC's validate Gateway image pipeline for kong/kong-gateway-dev:3.9.0.0-rc.5

Example: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12277898800/job/34258373712

This has been discussed in https://kongstrong.slack.com/archives/C011RQPHDC7/p1733915076647379.

Probable cause

Most likely this is related to bumping go-kong to 0.61.0

Possibly related code in KIC:

Logs observed running locally:

2024-12-12T11:44:41+01:00	debug	events	failed to apply Kong configuration to https://10.244.0.99:8444: 2 errors occurred:
	while processing event: Create consumer-group-consumer c2 failed: HTTP status 409 (message: "Consumer '6028905a-310f-5dc7-a1c0-c741e8ad3bae' already in group 'e723d40d-03a0-558e-9b17-fbc82ff50127'")
	while processing event: Create consumer-group-consumer cnew failed: HTTP status 409 (message: "Consumer 'c7dc7349-e049-585c-b537-a0060df634c7' already in group 'e723d40d-03a0-558e-9b17-fbc82ff50127'")

Acceptance criteria

  • KIC passes integration tests suite with go-kong newer than go-kong 0.60.0 running against Gateway 3.9 (RCs included) or newer
  • remove version pin from go.mod
@randmonkey
Copy link
Contributor

@pmalek I think the most possible breakage happens on the entity consumer_group_consumer.
From the log we can see KIC wants to create the consumer_group_consumer that has been created.

while processing event: Create consumer-group-consumer cnew failed: HTTP status 409 (message: "Consumer 'c7dc7349-e049-585c-b537-a0060df634c7' already in group 'e723d40d-03a0-558e-9b17-fbc82ff50127'")

I think it is likely that consumer_group_consumers was not listed with our config of resolving diffs in GDR so they are created again.

@pmalek pmalek added this to the KIC v3.5.x milestone Dec 12, 2024
@pmalek
Copy link
Member Author

pmalek commented Dec 12, 2024

@randmonkey You might be right. I don't know too much about this piece of code unfortunately.

Adding to v3.5.x so that this doesn't get lost in backlog.

@pmalek
Copy link
Member Author

pmalek commented Dec 12, 2024

For whoever picks this up: let's make sure to add a test for this to catch possible future errors earlier rather than later. Ideally this would be covered by a UT, kongintegration or envtest test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants