Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the scheme of redirect location as the same of the request when scheme is empty in RequestRedirect HTTPRoute filter when Kong redirect plugin supports #6856

Open
2 of 3 tasks
randmonkey opened this issue Dec 17, 2024 · 0 comments
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API

Comments

@randmonkey
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

The redirect plugin does not support a location without a scheme (example: konghq.com) to keep the scheme in the request, so we set the scheme of the location to http when scheme field is empty in RequestRedirect filter. This is not conformant with the gateway API specification where the scheme should be kept the same as the request if the scheme field is empty.

Proposed Solution

  • When redirect Kong plugin supports keeping scheme in the redirect location, configure the redirect plugin to keep the scheme of the location.

Additional information

No response

Acceptance Criteria

  • The scheme of redirect location is the same as the request when RequestRedirect filter does not specify a scheme.
@randmonkey randmonkey added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API
Projects
None yet
Development

No branches or pull requests

1 participant