-
Notifications
You must be signed in to change notification settings - Fork 10
Description
I was reviewing your the plugin in the marketplace, which lead me to also check out the repository. In your readme I found the following:
Do NOT try to add a new "networked printer"! This is only for Ultimaker printers.
This is not the case. A plugin can register itself as being able to detect (and add) printers manually. We try to ensure that we keep as much flexibility as possible within our plugins.
If you check the code that handles the check in the manual IP screen (https://github.com/Ultimaker/Cura/blob/78ecb7ec9a0c1deae6c322a286a13ee70a07e379/cura/Machines/Models/DiscoveredPrintersModel.py#L143-L164) you can see that it asks all the plugins if they can add a manual device given the address. If at that point the plugin responds that it's able, it will be considered in _attemptToManualAddDevice (https://github.com/Ultimaker/Cura/blob/78ecb7ec9a0c1deae6c322a286a13ee70a07e379/cura/Machines/Models/DiscoveredPrintersModel.py#L166-L174)