Skip to content

Use less generic env variables #3

Open
@nhoizey

Description

@nhoizey

The environment variable names are really generic:
https://github.com/KyleMit/eleventy-plugin-embed-tweet/blob/master/twitter.js#L56-L69

I have keys for multiple services in my .env file, so it would be better having a more distinctive name for these for Twitter.

Here are the names in Twitter's UI:
image

I suggest using these names, so follow Twitter naming:

current name   new name
TOKEN TWITTER_ACCESS_TOKEN
TOKEN_SECRET TWITTER_ACCESS_TOKEN_SECRET
CONSUMER_KEY TWITTER_API_KEY
CONSUMER_SECRET TWITTER_API_SECRET_KEY

If you agree with this, I can make a PR to use new names AND still support current ones for compatibility.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions