Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle both lumped and split biomass function #27

Open
stelmo opened this issue Oct 15, 2022 · 2 comments
Open

Handle both lumped and split biomass function #27

stelmo opened this issue Oct 15, 2022 · 2 comments
Labels
feedback needed

Comments

@stelmo
Copy link
Collaborator

stelmo commented Oct 15, 2022

Some models (e.g. community models, older models) employ split biomass functions that will fail most of the biomass function tests. Make the testing procedure robust against them.

@exaexa
Copy link
Collaborator

exaexa commented Nov 12, 2022

Is there some way to manage that? (pick one of the biomasses?) Or does that need to completely modify the test suite?

@exaexa exaexa added the feedback needed label Nov 12, 2022
@stelmo
Copy link
Collaborator Author

stelmo commented Nov 12, 2022

It requires us to identify when this happens and then dramatically change the test function unfortunately. Basically the biomass function for the older models looks something like this:

arginine + proline + ... + cysteine -> amino_acids
lipid_1 + lipid_2 -> all_lipids
...
amino_acids + all_lipids + ... -> biomass

I think they handle this in memote.py, but I forgot where...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback needed
Projects
None yet
Development

No branches or pull requests

2 participants