Skip to content

Commit 03d35fc

Browse files
michaelmckinsey1michaelmckinsey1
committed
Remove argument from function
1 parent 313ff73 commit 03d35fc

File tree

23 files changed

+31
-31
lines changed

23 files changed

+31
-31
lines changed

Diff for: ‎experiments/ad/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def compute_applications_section(self):
2424
self.add_experiment_variable("n_ranks", 1, True)
2525
self.add_experiment_variable("n_threads_per_proc", 1, True)
2626

27-
def compute_package_section(self, pkg_manager):
27+
def compute_package_section(self):
2828
# get package version
2929
app_version = self.spec.variants["version"][0]
3030

Diff for: ‎experiments/amg2023/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def compute_applications_section(self):
133133
elif self.spec.satisfies("+cuda") or self.spec.satisfies("+rocm"):
134134
self.add_experiment_variable("n_gpus", n_resources, True)
135135

136-
def compute_package_section(self, pkg_manager):
136+
def compute_package_section(self):
137137
# get package version
138138
app_version = self.spec.variants["version"][0]
139139

Diff for: ‎experiments/babelstream/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def compute_applications_section(self):
5353
if self.spec.satisfies("+cuda") or self.spec.satisfies("+rocm"):
5454
self.add_experiment_variable("n_gpus", n_resources, True)
5555

56-
def compute_package_section(self, pkg_manager):
56+
def compute_package_section(self):
5757
# get package version
5858
app_version = self.spec.variants["version"][0]
5959

Diff for: ‎experiments/genesis/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def compute_applications_section(self):
4848
self.add_experiment_variable("omp_num_threads", ["12"])
4949
self.add_experiment_variable("arch", "OpenMP")
5050

51-
def compute_package_section(self, pkg_manager):
51+
def compute_package_section(self):
5252
# get package version
5353
app_version = self.spec.variants["version"][0]
5454

Diff for: ‎experiments/gpcnet/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def compute_applications_section(self):
3232
elif self.spec.satisfies("workload=network_load_test"):
3333
self.add_experiment_variable("n_nodes", "10")
3434

35-
def compute_package_section(self, pkg_manager):
35+
def compute_package_section(self):
3636
# get package version
3737
app_version = self.spec.variants["version"][0]
3838

Diff for: ‎experiments/gromacs/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def compute_applications_section(self):
8686
for k, v in other_input_variables.items():
8787
self.add_experiment_variable(k, v)
8888

89-
def compute_package_section(self, pkg_manager):
89+
def compute_package_section(self):
9090
# get package version
9191
app_version = self.spec.variants["version"][0]
9292

Diff for: ‎experiments/hpcg/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def compute_applications_section(self):
7979

8080
self.add_experiment_variable("iterations", "60", False)
8181

82-
def compute_package_section(self, pkg_manager):
82+
def compute_package_section(self):
8383
# get package version
8484
app_version = self.spec.variants["version"][0]
8585

Diff for: ‎experiments/hpl/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def compute_applications_section(self):
9898
problem_size = scaled_variables["Ns"]
9999
self.add_experiment_variable("Ns", problem_size, True)
100100

101-
def compute_package_section(self, pkg_manager):
101+
def compute_package_section(self):
102102
# get package version
103103
app_version = self.spec.variants["version"][0]
104104

Diff for: ‎experiments/ior/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def compute_applications_section(self):
7878
"n_ranks", "{sys_cores_per_node} * {n_nodes}", True
7979
)
8080

81-
def compute_package_section(self, pkg_manager):
81+
def compute_package_section(self):
8282
# get package version
8383
app_version = self.spec.variants["version"][0]
8484

Diff for: ‎experiments/kripke/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def compute_applications_section(self):
136136
elif self.spec.satisfies("+rocm"):
137137
self.add_experiment_variable("arch", "HIP")
138138

139-
def compute_package_section(self, pkg_manager):
139+
def compute_package_section(self):
140140
# get package version
141141
app_version = self.spec.variants["version"][0]
142142

Diff for: ‎experiments/laghos/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def compute_applications_section(self):
5959
num_resources = scaled_variables["n_nodes"]
6060
self.add_experiment_variable(device, num_resources, True)
6161

62-
def compute_package_section(self, pkg_manager):
62+
def compute_package_section(self):
6363
# get package version
6464
app_version = self.spec.variants["version"][0]
6565

Diff for: ‎experiments/lammps/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def compute_applications_section(self):
9191
False,
9292
)
9393

94-
def compute_package_section(self, pkg_manager):
94+
def compute_package_section(self):
9595
# get package version
9696
app_version = self.spec.variants["version"][0]
9797

Diff for: ‎experiments/md-test/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def compute_applications_section(self):
4343
for k, v in scaled_variables.items():
4444
self.add_experiment_variable(k, v, True)
4545

46-
def compute_package_section(self, pkg_manager):
46+
def compute_package_section(self):
4747
# get package version
4848
app_version = self.spec.variants["version"][0]
4949

Diff for: ‎experiments/osu-micro-benchmarks/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def compute_applications_section(self):
112112
for pk, pv in num_nodes.items():
113113
self.add_experiment_variable("n_gpus", pv, True)
114114

115-
def compute_package_section(self, pkg_manager):
115+
def compute_package_section(self):
116116
system_specs = {}
117117
if self.spec.satisfies("+cuda"):
118118
system_specs["cuda_version"] = "{default_cuda_version}"

Diff for: ‎experiments/phloem/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def compute_applications_section(self):
3636
elif self.spec.satisfies("workload=mpiGraph"):
3737
self.add_experiment_variable("n_ranks", "2")
3838

39-
def compute_package_section(self, pkg_manager):
39+
def compute_package_section(self):
4040
# get package version
4141
app_version = self.spec.variants["version"][0]
4242

Diff for: ‎experiments/quicksilver/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def compute_applications_section(self):
4949
self.add_experiment_variable("J", ["2", "2", "2", "4"])
5050
self.add_experiment_variable("K", ["1", "2", "2", "2"])
5151

52-
def compute_package_section(self, pkg_manager):
52+
def compute_package_section(self):
5353
# get package version
5454
app_version = self.spec.variants["version"][0]
5555

Diff for: ‎experiments/qws/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def compute_applications_section(self):
4747
self.add_experiment_variable("omp_num_threads", ["48"])
4848
self.add_experiment_variable("arch", "OpenMP")
4949

50-
def compute_package_section(self, pkg_manager):
50+
def compute_package_section(self):
5151
# get package version
5252
app_version = self.spec.variants["version"][0]
5353

Diff for: ‎experiments/raja-perf/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def compute_applications_section(self):
5858
else:
5959
self.add_experiment_variable("n_ranks", n_resources, True)
6060

61-
def compute_package_section(self, pkg_manager):
61+
def compute_package_section(self):
6262
# get package version
6363
app_version = self.spec.variants["version"][0]
6464

Diff for: ‎experiments/remhos/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def compute_applications_section(self):
8585
elif self.spec.satisfies("+rocm"):
8686
self.add_experiment_variable("arch", "HIP")
8787

88-
def compute_package_section(self, pkg_manager):
88+
def compute_package_section(self):
8989
# get package version
9090
app_version = self.spec.variants["version"][0]
9191

Diff for: ‎experiments/saxpy/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def compute_applications_section(self):
4242

4343
self.add_experiment_variable("n", n, True)
4444

45-
def compute_package_section(self, pkg_manager):
45+
def compute_package_section(self):
4646
# get package version
4747
app_version = self.spec.variants["version"][0]
4848

Diff for: ‎experiments/smb/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def compute_applications_section(self):
3333
self.add_experiment_variable("n_nodes", "1")
3434
self.add_experiment_variable("n_ranks", "{n_nodes}*{sys_cores_per_node}")
3535

36-
def compute_package_section(self, pkg_manager):
36+
def compute_package_section(self):
3737
# get package version
3838
app_version = self.spec.variants["version"][0]
3939

Diff for: ‎experiments/stream/experiment.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def compute_applications_section(self):
4141
for pk, pv in array_size.items():
4242
self.add_experiment_variable(pk, pv, True)
4343

44-
def compute_package_section(self, pkg_manager):
44+
def compute_package_section(self):
4545
# get package version
4646
app_version = self.spec.variants["version"][0]
4747

Diff for: ‎lib/benchpark/experiment.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def compute_modifiers_section(self):
4343
def compute_applications_section(self):
4444
return {}
4545

46-
def compute_package_section(self, pkg_manager):
46+
def compute_package_section(self):
4747
return {}
4848

4949
def get_helper_name_prefix(self):
@@ -294,7 +294,7 @@ def add_package_spec(self, package_name, spec=None):
294294
else:
295295
self.package_specs[package_name] = {}
296296

297-
def compute_package_section(self, pkg_manager):
297+
def compute_package_section(self):
298298
raise NotImplementedError(
299299
"Each experiment must implement compute_package_section"
300300
)
@@ -303,18 +303,18 @@ def compute_package_section_wrapper(self):
303303
pkg_manager = self.spec.variants["package_manager"][0]
304304

305305
for cls in self.helpers:
306-
cls_package_specs = cls.compute_package_section(pkg_manager)
306+
cls_package_specs = cls.compute_package_section()
307307
if cls_package_specs and "packages" in cls_package_specs:
308308
self.package_specs |= cls_package_specs["packages"]
309309

310-
self.compute_package_section(pkg_manager)
310+
self.compute_package_section()
311311

312-
if pkg_manager == "spack":
313-
if self.name not in self.package_specs:
314-
raise BenchparkError(
315-
f"Package section must be defined for application package {self.name}"
316-
)
312+
if self.name not in self.package_specs:
313+
raise BenchparkError(
314+
f"Package section must be defined for application package {self.name}"
315+
)
317316

317+
if pkg_manager == "spack":
318318
spack_variants = list(
319319
filter(
320320
lambda v: v is not None,

0 commit comments

Comments
 (0)