Changes to SUNDIALS API and core C/C++ needed for Python interfaces#768
Merged
balos1 merged 83 commits intofeature/python-interfacesfrom Oct 7, 2025
Merged
Changes to SUNDIALS API and core C/C++ needed for Python interfaces#768balos1 merged 83 commits intofeature/python-interfacesfrom
balos1 merged 83 commits intofeature/python-interfacesfrom
Conversation
balos1
requested review from
cswoodward,
drreynolds and
gardner48
as code owners
…r constant expression folding
Member
Author
|
@gardner48 When this is merged into the feature/python-interfaces branch, I don't want the commits squashed so that I don't get a bunch of merge conflicts between this part1 branch and part2. |
gardner48
requested changes
Oct 3, 2025
Member
|
General question on the C++ wrappers, how is error handling done? For examples, what happens if one of the C constructors returns |
Member
Author
The view will just hold a |
gardner48
requested changes
Oct 7, 2025
gardner48
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the changes that are needed to enable the Python interfaces without the bindings themselves included to make the review process easier.