Compatibility with CMake < 3.5 has been removed from CMake

[DINKIN]

System Information

OS: EndeavourOS x86_64 Kernel: Linux 6.14.0-arch1-1 CPU: AMD Ryzen Threadripper 1900X (16) @ 3.80 GHz

LMMS Version(s)

git

Most Recent Working Version

No response

Bug Summary

aur helper cannot sucessfully build lmms-git

Expected Behaviour

i expect paru to build the lmms-git sucessfully

Steps To Reproduce

use any aur helper and try to build lmms-git

Logs

Click to expand

  
-- Old winegcc detected, trying to use workaround linking
CMake Warning at cmake/modules/FindWine.cmake:128 (MESSAGE):
Can't detect wine installation layout.  You may get some build errors.
Call Stack (most recent call first):
CMakeLists.txt:566 (find_package)
-- Found Wine: /usr/bin/wineg++

--   WINE_INCLUDE_DIR:     /usr/include/wine/windows

--   WINE_CXX:             /usr/bin/wineg++

--   WINE_GCC:             /usr/bin/winegcc

--   WINE_32_FLAGS:

--   WINE_64_FLAGS:

-- Found Samplerate: /usr/lib/libsamplerate.so.0.2.2 (found suitable version "0.2.2", minimum required is "0.1.8")

-- Setting build type to 'Release' as none was specified.

CMake Error at src/3rdparty/qt5-x11embed/CMakeLists.txt:1 (cmake_minimum_required):

Compatibility with CMake < 3.5 has been removed from CMake.
Update the VERSION argument  value.  Or, use the ... syntax

to tell CMake that the project requires at least  but has been updated

to work with policies introduced by  or earlier.
Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
-- Configuring incomplete, errors occurred!

==> ERROR: A failure occurred in build().

Aborting...

error: failed to build 'lmms-git-1.3.0.alpha.1.r236.g20baf96db-1':

error: packages failed to build: lmms-git-1.3.0.alpha.1.r236.g20baf96db-1

Screenshots / Minimum Reproducible Project

Please search the issue tracker for existing bug reports before submitting your own.

• I have searched all existing issues and confirmed that this is not a duplicate.

[deadYokai]

after cmake update, versions before 3.5 is not supported, and it not building because qt5-x11embed uses version 2.8.12
as workaround i put this line

sed 's/VERSION 2.8.12/VERSION 3.9/g' -i "$srcdir/lmms/src/3rdparty/qt5-x11embed/CMakeLists.txt"

in end of prepare section inside PKGBUILD

[michaelgregorius]

This problem also shows up for the Linux x64 builds on the build servers, e.g.: https://github.com/LMMS/lmms/actions/runs/14201637873/job/39789759396?pr=7525.

A workaround seems to be to use -DCMAKE_POLICY_VERSION_MINIMUM=3.5 as for example proposed here. IMO it would be the cleaner solution because it addresses the problem at the root, i.e. at the CMake call itself. Haven't really had the chance to test it though.

[michaelgregorius]

A potential fix for the build servers is provided by PR #7825. It uses the CMAKE_POLICY_VERSION_MINIMUM option.

An alternative might be to fix this upstream in https://github.com/lukas-w/qt5-x11embed/blob/022b39a1d496d72eb3e5b5188e5559f66afca957/CMakeLists.txt so that the patch described by @deadYokai is not necessary anymore. This might be a viable option as everything still seems to compile with the patch which indicates that there should be no incompatibilities that arise by simply incrementing the minimum version to 3.9. It would also fix the problem everywhere. Otherwise maintainers and builders would have to be aware to use CMAKE_POLICY_VERSION_MINIMUM if they use CMake 4 or newer. Arch Linux for example is already on CMake 4: https://archlinux.org/packages/extra/x86_64/cmake/.

An intermediate step might be to merge #7825 to get the Linux x64 builds working again, fix the problem upstream and then optionally remove the changes made by #7825 again.

[michaelgregorius]

@DINKIN, this will likely be fixed via this PR in an upstream repository: lukas-w/qt5-x11embed#7.

[tresf]

@DINKIN can you please test #7825 and see if it fixes this issue for you? It would be helpful if you also ensure that X11 embedding is still functioning (well, functioning as well as it does on nightly at least)

[michaelgregorius]

If we are talking about the following AUR package then I am not sure if it will build without further adjustments in the first place: https://aur.archlinux.org/packages/lmms-git.

The PKGBUILD file seems to have the following issues:

• It does not list qt5-svg as a dependency (in fact it only references Qt5 via an indirect dependency of qt5-x11extras)
• It lists the following sources explicitly. These are already sub-modules though:
  • git+https://github.com/Lukas-W/qt5-x11embed.git
  • git+https://github.com/rampantpixels/rpmalloc.git (to my knowledge that dependency was removed some time ago)
• The pkgver function results in "1.1.3.something" instead of 1.2 or 1.3.

I was able to build a test package with the following adjusted PKGBUILD file:

# Maintainer: Difarem <difarem@gmail.com>
# Contributor: David Runge <dave@sleepmap.de>
# Contributor: Xyne
# Contributor: Scott Garrett <Wintervenom@archlinux.us>
# Contributor: Thomas Dziedzic

_name=lmms
pkgname=lmms-git
pkgver=1.1.3.r4179.g25a0eb6ab
pkgrel=1
pkgdesc='The Linux MultiMedia Studio.'
arch=('x86_64')
url="https://lmms.io"
license=('GPL2')
depends=('fftw' 'fltk' 'fluidsynth' 'lame' 'libgig' 'qt5-svg' 'qt5-x11extras' 'sdl'
'stk')
optdepends=('pulseaudio: pulseaudio support'
            'wine: VST plugin support'
            'carla: carla support')
makedepends=('cmake' 'doxygen' 'extra-cmake-modules' 'freetype2' 'git'
'ladspa' 'qt5-tools' 'wine' 'perl-list-moreutils' 'perl-xml-parser')
provides=('lmms')
conflicts=('lmms')
source=("git+https://github.com/michaelgregorius/lmms.git")
sha512sums=('SKIP')

pkgver() {
  cd "${_name}"
  git describe --long --tags | sed -r 's/^v//;s/([^-]*-g)/r\1/;s/-/./g'
}

prepare() {
  cd "${_name}"
  mkdir -vp build
  git checkout FixForCMake4BuildsOnBuildServer
  git submodule init
  git -c protocol.file.allow=always submodule update
  # setting lib dir
  sed -e 's|lib64|lib|g' -i cmake/modules/DetectMachine.cmake
  # setting proper DESTDIR based install path for bash-completion
  #sed -e 's/\(${BASHCOMP_USER\)/\\$DESTDIR\1/g' -i cmake/modules/BashCompletion.cmake
  #above commented beacuse of variable duplication (cmake module already puts $DESTDIR in shellfile,so replacing  ${BASHCOMP_USER_PATH} with $DESTDIR is reduntant)
  sed -e 's/\(${BASHCOMP_USER\)/\1/g' -i cmake/modules/BashCompletion.cmake
}

build() {
  #first we patch the generated destdir in shell
  #echo "Patching dir for autocompletion."
  #patch < fix_bash_completion_dir.patch
  #echo "Done"
  cd "${_name}/build"
  cmake -DCMAKE_INSTALL_PREFIX=/usr \
        -DWANT_QT5=ON \
        -DWANT_SOUNDIO=OFF \
        -DCMAKE_INSTALL_LIBDIR=lib \
        -DCMAKE_MODULE_PATH=/usr/share/ECM/find-modules \
        -DCMAKE_PREFIX_PATH=/usr/include/wine/windows \
        -DWINE_INCLUDE_DIR=/usr/include/wine/windows \
        -DWINE_LIBRARY=/usr/lib32/wine \
        ..
  make
}

package() {
  cd "${_name}/build"
  make DESTDIR="$pkgdir" install
}

# vim:set ts=2 sw=2 et:

If this is used as a basis for an adjusted PKGBUILD in the repo then the source will have to be switched from git+https://github.com/michaelgregorius/lmms.git to git+https://github.com/${_name}/${_name}.git again and the line which checks out my branch FixForCMake4BuildsOnBuildServer in the prepare statement must be removed.

Note: I had to add the multilib package source manually to install wine. So the PKGBUILD seems to expect a certain environment which cannot be instantiated via the file itself?

[Jamim]

Corresponding bug in Gentoo's Bugzilla:

• Bug 957460 - media-sound/lmms-1.2.2-r3 - QA Notice: Compatibility with CMake < 3.5 has been removed from CMake 4; CMake Error at CMakeLists.txt:11 (CMAKE_POLICY): Policy CMP0026 may not be set to OLD behavior because this version of CMake no longer supports it