commit: small fixes

LNP-BP · Nov 2, 2024 · c8bb6f1 · c8bb6f1
1 parent 277b4fa
commit c8bb6f1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/commit_verify/derive/src/params.rs b/commit_verify/derive/src/params.rs
@@ -45,6 +45,7 @@ pub enum StrategyAttr {
     ConcealStrict,
     Transparent,
     Merklize,
+    // TODO: Add Hash strategy
 }
 
 impl TryFrom<&Path> for StrategyAttr {

diff --git a/commit_verify/src/id.rs b/commit_verify/src/id.rs
@@ -110,7 +110,7 @@ impl CommitEngine {
 
     pub fn commit_to_hash<T: CommitEncode<CommitmentId = StrictHash> + StrictType>(
         &mut self,
-        value: T,
+        value: &T,
     ) {
         let fqn = commitment_fqn::<T>();
         self.layout
@@ -209,9 +209,6 @@ impl CommitEngine {
     pub fn finish_layout(self) -> (Sha256, TinyVec<CommitStep>) { (self.hasher, self.layout) }
 }
 
-/// Prepares the data to the *consensus commit* procedure by first running
-/// necessary conceal and merklization procedures, and them performing strict
-/// encoding for the resulted data.
 pub trait CommitEncode {
     /// Type of the resulting commitment.
     type CommitmentId: CommitmentId;
@@ -263,7 +260,7 @@ where T: CommitEncode + StrictDumb
 
 /// High-level API used in client-side validation for producing a single
 /// commitment to the data, which includes running all necessary procedures like
-/// concealment with [`crate::Conceal`], merklization, strict encoding,
+/// concealment with [`Conceal`], merklization, strict encoding,
 /// wrapped into [`CommitEncode`], followed by the actual commitment to its
 /// output.
 ///
@@ -291,7 +288,7 @@ impl<T: CommitEncode> CommitId for T {
 
 #[derive(Wrapper, Copy, Clone, Ord, PartialOrd, Eq, PartialEq, Hash, Debug, From)]
 #[wrapper(Deref, BorrowSlice, Display, FromStr, Hex, Index, RangeOps)]
-#[derive(StrictDumb, strict_encoding::StrictType, StrictEncode, StrictDecode)]
+#[derive(StrictDumb, StrictType, StrictEncode, StrictDecode)]
 #[strict_type(lib = LIB_NAME_COMMIT_VERIFY)]
 #[cfg_attr(
     feature = "serde",

diff --git a/commit_verify/src/merkle.rs b/commit_verify/src/merkle.rs
@@ -202,6 +202,7 @@ impl MerkleHash {
 
 pub trait MerkleLeaves {
     type Leaf: CommitId<CommitmentId = MerkleHash>;
+    // TODO: Remove associated type
     type LeafIter<'tmp>: ExactSizeIterator<Item = Self::Leaf>
     where Self: 'tmp;