Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeriodicMetric undersamples frequencies #59

Open
keatonb opened this issue Jul 15, 2018 · 0 comments
Open

PeriodicMetric undersamples frequencies #59

keatonb opened this issue Jul 15, 2018 · 0 comments

Comments

@keatonb
Copy link
Contributor

keatonb commented Jul 15, 2018

Taking a look to see how well existing MAF metrics quantify problems with the window function, it appears that the periodigram computed in PeriodicMetric is very undersampled (assuming the 10 year baseline is evaluated). As a result, it will miss most peaks entirely and poorly characterize those that it does observe. I recommend increasing the frequency sampling to oversample 1/baseline by a factor of 5-10. @lundmb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant