Skip to content

Commit cc50651

Browse files
authored
change dialect to generic (#410)
1 parent a03e407 commit cc50651

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

parsil/src/parser.rs

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@ use anyhow::*;
22
use log::*;
33
use sqlparser::{
44
ast::{Query, Statement},
5-
dialect::AnsiDialect,
5+
dialect::GenericDialect,
66
parser::Parser,
77
};
88

9-
use crate::{symbols::ContextProvider, utils::ParsilSettings};
9+
const DIALECT: GenericDialect = GenericDialect {};
1010

11-
const DIALECT: AnsiDialect = AnsiDialect {};
12-
13-
pub fn parse<C: ContextProvider>(_settings: &ParsilSettings<C>, req: &str) -> Result<Query> {
11+
pub fn parse(req: &str) -> Result<Query> {
1412
debug!("Parsing `{req}`");
1513
let mut parsed =
1614
Parser::parse_sql(&DIALECT, req).with_context(|| format!("trying to parse `{req}`"))?;
@@ -27,3 +25,14 @@ pub fn parse<C: ContextProvider>(_settings: &ParsilSettings<C>, req: &str) -> Re
2725
bail!("expected query, found `{}`", parsed[0])
2826
}
2927
}
28+
29+
#[cfg(test)]
30+
mod test {
31+
use super::parse;
32+
33+
#[test]
34+
fn test_parsing_query_underscore() {
35+
let req = "SELECT AVG(value / _totalSupply) FROM myTable;";
36+
parse(req).unwrap();
37+
}
38+
}

parsil/src/utils.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ pub fn parse_and_validate<C: ContextProvider>(
191191
query: &str,
192192
settings: &ParsilSettings<C>,
193193
) -> anyhow::Result<Query> {
194-
let mut query = parser::parse(&settings, query)?;
194+
let mut query = parser::parse(query)?;
195195
expand::expand(&settings, &mut query)?;
196196

197197
placeholders::validate(settings, &query)?;

0 commit comments

Comments
 (0)