Code Quality: Added protection for System.DivideByZeroException (files-community#17031)

yaira2 · web-flow · commit 87730e3efe62 · 2025-04-08T18:28:14.000-04:00
diff --git a/src/Files.App.Controls/AdaptiveGridView/AdaptiveGridView.Properties.cs b/src/Files.App.Controls/AdaptiveGridView/AdaptiveGridView.Properties.cs
@@ -152,7 +152,7 @@ private double ItemWidth
 
 		private static int CalculateColumns(double containerWidth, double itemWidth)
 		{
-			var columns = (int)Math.Round(containerWidth / itemWidth);
+			var columns = itemWidth > 0 ? (int)Math.Round(containerWidth / itemWidth) : 0;
 			if (columns == 0)
 			{
 				columns = 1;
diff --git a/src/Files.App.Controls/AdaptiveGridView/AdaptiveGridView.cs b/src/Files.App.Controls/AdaptiveGridView/AdaptiveGridView.cs
@@ -119,7 +119,7 @@ protected virtual double CalculateItemWidth(double containerWidth)
 				_needContainerMarginForLayout = true;
 			}
 
-			return (containerWidth / columns) - itemMargin.Left - itemMargin.Right;
+			return columns > 0 ? (containerWidth / columns) - itemMargin.Left - itemMargin.Right : 0;
 		}
 
 		/// <summary>

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ private double ItemWidth`
`152`	`152`
`153`	`153`	`private static int CalculateColumns(double containerWidth, double itemWidth)`
`154`	`154`	`{`
`155`		`- var columns = (int)Math.Round(containerWidth / itemWidth);`
	`155`	`+ var columns = itemWidth > 0 ? (int)Math.Round(containerWidth / itemWidth) : 0;`
`156`	`156`	`if (columns == 0)`
`157`	`157`	`{`
`158`	`158`	`columns = 1;`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ protected virtual double CalculateItemWidth(double containerWidth)`
`119`	`119`	`_needContainerMarginForLayout = true;`
`120`	`120`	`}`
`121`	`121`
`122`		`- return (containerWidth / columns) - itemMargin.Left - itemMargin.Right;`
	`122`	`+ return columns > 0 ? (containerWidth / columns) - itemMargin.Left - itemMargin.Right : 0;`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`/// <summary>`