Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path marked as loaded even if the result is DISABLED #136

Open
susanu opened this issue Aug 27, 2024 · 0 comments
Open

Path marked as loaded even if the result is DISABLED #136

susanu opened this issue Aug 27, 2024 · 0 comments
Assignees

Comments

@susanu
Copy link

susanu commented Aug 27, 2024

Hi guys,

Seems that if you call basset on the same path more than once, it marks the path as loaded even if the result is disabled.
Example url: https://www.gravatar.com/avatar/a3a2e97ccd20ce09e1e0049da479c073.jpg?s=80&d=blank&r=g

First call returns DISABLED and use the original url https://www.gravatar.com/avatar/a3a2e97ccd20ce09e1e0049da479c073.jpg?s=80&d=blank&r=g
Second call returns LOADED and use an internal url which doesn't exist https://example.com/storage/basset/www.gravatar.com/avatar/a3a2e97ccd20ce09e1e0049da479c073.jpg

I think you should not mark the path as loaded if the file is not internalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants