Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "mining" blocks in regtest mode #37

Closed
nchashch opened this issue Oct 11, 2024 · 4 comments · Fixed by #41
Closed

Implement "mining" blocks in regtest mode #37

nchashch opened this issue Oct 11, 2024 · 4 comments · Fixed by #41
Assignees

Comments

@nchashch
Copy link
Collaborator

nchashch commented Oct 11, 2024

There is already an implementation of this in the bip300301_wallet repository, just move it here.

@torkelrogstad
Copy link
Contributor

What's your opinion on the idea brought up in this discussion in the protos repo?

LayerTwo-Labs/cusf_sidechain_proto#5 (comment)

I've implemented functionality for adding coinbase messages to the signet miner here: LayerTwo-Labs/bitcoin-patched#6

Doing this approach in regtest as well could be a good way of testing that it works properly. And it would let us omit the generate RPC

@nchashch
Copy link
Collaborator Author

It would be easier to copy over the block construction from bip300301_wallet implementation.

@nchashch nchashch self-assigned this Oct 17, 2024
@torkelrogstad
Copy link
Contributor

I'm pretty sure that won't work on signet, though?

@nchashch
Copy link
Collaborator Author

nchashch commented Oct 17, 2024

Yes, but we need to get it to work with regtest first. We can worry about signet later.

Because all the other things we need to integrate Thunder and Enforcer depend on this working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants