Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tests on DVNAdapter in DVN.t.sol #56

Open
abhi3700 opened this issue Apr 10, 2024 · 0 comments
Open

No tests on DVNAdapter in DVN.t.sol #56

abhi3700 opened this issue Apr 10, 2024 · 0 comments

Comments

@abhi3700
Copy link

When looking into DVN.t.sol file, at the setup level, there is no deployment of DVNAdapter contract. Neither there is any dependency or call made on DVNAdapter contract in the tests.
I thought it should have been as per this diagram of DVN Adapter:
image

Can we have those added please?
@jipan76 jipan76 mentioned this issue Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhi3700