Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate enchanting level for enchantment tables. #271

Open
2 tasks
Tracked by #272
skillman623 opened this issue Feb 26, 2023 · 3 comments
Open
2 tasks
Tracked by #272

Calculate enchanting level for enchantment tables. #271

skillman623 opened this issue Feb 26, 2023 · 3 comments

Comments

@skillman623
Copy link

skillman623 commented Feb 26, 2023

  • Enchantment tables should calculate max enchant based off of surrounding bookshelves.
  • There should be an option to support custom bookshelves too (such as Botania's mana pylon).
@cooltexture1
Copy link
Contributor

Most of that logic is handled by the server tho. The server sends information about the level requirement and the possible enchantments via this packet. In PR #269 the enchantment table works by just displaying the information the server is sending.

@terrarier2111
Copy link
Member

Most of that logic is handled by the server tho. The server sends information about the level requirement and the possible enchantments via this packet. In PR #269 the enchantment table works by just displaying the information the server is sending.

Do you think we can mark this as closed?

@cooltexture1
Copy link
Contributor

yes i think so, although the enchatning table has an issue where ghost items often appear when using it. but the enchanting process itself and the display of the required levels works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants