Fix major issues reported by SonarQube

Author: meecash

memcr.c

@@ -356,7 +356,7 @@ static void md5_final(unsigned char *md, unsigned int *len, void *ctx)
 }
 #endif
 
-static void parasite_status_signal(pid_t pid, int status)
+static void parasite_status_signal(int status)
 {
 	pthread_mutex_lock(&parasite_watch.lock);
 	parasite_watch.changed = 1;
@@ -449,7 +449,7 @@ static void cleanup_pid(pid_t pid)
 
 static int iterate_pstree(pid_t pid, int skip_self, int max_threads, int (*callback)(pid_t pid))
 {
-	int ret;
+	int ret = -1;
 	char path[PATH_MAX];
 	DIR *task_dir;
 	struct dirent *ent;
@@ -1208,6 +1208,8 @@ static void get_target_rss(pid_t tid, struct vm_stats *vms)
 	FILE *f;
 	char buf[1024];
 
+	memset(vms, 0x0, sizeof(struct vm_stats));
+
 	f = fopen_proc(tid, "status");
 	if (!f)
 		return;
@@ -1526,6 +1528,7 @@ static int get_vma_pages(int pd, int md, int cd, struct vm_area *vma, int fd)
 				ret = parasite_write_read(cd, &req, (void*)map_buf, req.u.pagemap.len);
 				if (ret != req.u.pagemap.len) {
 					fprintf(stderr, "parasite_write_read() %d / %ld\n", ret, req.u.pagemap.len);
+					free(map_buf);
 					return -1;
 				}
 			}
@@ -1984,7 +1987,7 @@ static int peek(pid_t pid, unsigned long *addr, unsigned long *dst, size_t len)
 
 static int poke(pid_t pid, unsigned long *addr, unsigned long *src, size_t len)
 {
-	int ret;
+	int ret = -1;
 	int i;
 
 	/* len must be a multiple of CPU word size */
@@ -2141,7 +2144,7 @@ static void *parasite_watch_thread(void *ptr)
 		return NULL;
 	}
 
-	parasite_status_signal(pid, status);
+	parasite_status_signal(status);
 
 	return NULL;
 }
@@ -2260,6 +2263,11 @@ static int execute_parasite_checkpoint(pid_t pid)
 
 	/* mmap space for parasite */
 	ret = execute_blob(&ctx, mmap_blob, mmap_blob_size, sizeof(parasite_blob), 0);
+	/* -4096LU is expanded to 0xFFFFF000 in 32bits, 
+	 * 0xFFFFF000 is max valid VMA address for 32bits,
+	 * the executed mmap_blob calls mmap syscall, which returns errors as small negative integers
+	 * so the comparison against 0xFFFFF000 will catch those errors - in fact any value being not a valid address
+	 */
 	if (ret >= -4096LU) {
 		fprintf(stdout, "[-] mmap failed: %lx\n", ret);
 		signals_unblock(pid);