-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
Describe the bug
I was troubleshooting an issue I was having with the rsyslog addon and figured out it all came back to a problem with where Kodi is storing my addon settings and where LE's helper scripts are telling the addon to look. After looking at 00-addon.conf's oe_setup_addon it looks to me like LE always tells addons to use the Master users settings path and does not look to see if a profile is in use and a different path should be returned. The problem is Kodi's GUI will make changes to the active profiles addon_data folder when you make changes through the GUI with the end effect that you can't configure any addons with a profile active.
I'd submit a fix, but I'm not sure what the correct way to detect that a different profile is active. It looks like $CUR and $ADDON_HOME both need to be profile aware.
How to reproduce
Steps to reproduce the behavior:
- Activate a non-Master profile in Kodi
- Install an addon like rsyslog and make settings changes through the GUI
- Kodi updates /storage/.kodi/userdata/profiles/[your-profile-name]/addon_data/services.rsyslog/settings.xml
- Supporting scripts, like addons/services.rsyslog/bin/rsyslog.init will still be getting /storage/.kodi/userdata/addon_data/services.rsyslog/settings.xml instead of /storage/.kodi/userdata/profiles/[your-profile-name]/addon_data/services.rsyslog/settings.xml
Information
- LibreELEC Version: 11.03
- Hardware Platform: x86 and RPi4
Log file
I couldn't find anything actually logged for this. It was just a lot of modifying LE scripts to see what the current state of env variables was.
Context
Originally I thought this was a library path issue since rsyslog did nothing with any config that was set, but that ended up being a problem with my testing.
#8044