Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtractionOnlyPrologueTransform for dropping checks form the prologue #1531

Open
t-vi opened this issue Dec 9, 2024 · 0 comments
Open

ExtractionOnlyPrologueTransform for dropping checks form the prologue #1531

t-vi opened this issue Dec 9, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers jit thunderfx for things that could be applicable to the dynamo+thunder frontend

Comments

@t-vi
Copy link
Collaborator

t-vi commented Dec 9, 2024

The prologue can take a considerable amount of time.

Currently, the prologue does two things:

  1. extract values for the computation trace,
  2. check shapes and other metadata.

In situations where the user controls the environment, it makes sense to let them take control and offer to skip 2.

It would be nice to have a ExtractionOnlyPrologueTransform . For bonus points, use the TraceSubstitutionProcessor.
@t-vi t-vi added enhancement New feature or request good first issue Good for newcomers jit labels Dec 9, 2024
@tfogal tfogal added the thunderfx for things that could be applicable to the dynamo+thunder frontend label Dec 13, 2024
@tfogal tfogal mentioned this issue Dec 13, 2024
Open
@t-vi t-vi mentioned this issue Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers jit thunderfx for things that could be applicable to the dynamo+thunder frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfogal @t-vi