Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Don't validate tensor metadata for parameter tensors by default #1542

Open
mruberry opened this issue Dec 11, 2024 · 0 comments
Open

UX: Don't validate tensor metadata for parameter tensors by default #1542

mruberry opened this issue Dec 11, 2024 · 0 comments
Assignees
@kshitij12345
Labels
performance thunderfx for things that could be applicable to the dynamo+thunder frontend ux

Comments

@mruberry
Copy link
Collaborator

mruberry commented Dec 11, 2024 •
edited by github-actions bot
Loading

torch.compile doesn't validate this metadata by default. Practitioners have to set

torch._dynamo.config.guard_nn_modules=True

Not validating the parameter metadata could reduce startup latency. Maybe we should not validate parameters by default, too, and have an option to enable it?

cc @Borda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshitij12345 kshitij12345

Labels
performance thunderfx for things that could be applicable to the dynamo+thunder frontend ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tfogal @kshitij12345 @mruberry