New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky code coverage #1547

Open

mruberry opened this issue Dec 12, 2024 · 0 comments

Labels

ci

Collaborator

mruberry commented Dec 12, 2024 •

edited by github-actions bot

Loading

Seems like code coverage can cause CI failures like:

Wrote XML report to coverage.xml
+ ./codecov --token=*** --commit=5efa041b7c2b6f256bf1571a043d58267faaf3e1 --flags=gpu,pytest,networks --name=GPU-coverage --env=linux,azure
/__w/_temp/b50911ff-a252-4a97-8003-3fbfbb5d1ac2.sh: line 14: ./codecov: No such file or directory

##[error]Bash exited with code '127'.

See https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_apis/build/builds/221986/logs/43 for an example.

I'm not sure what these code coverage reports do. Maybe we should remove them, or not fail the CI if they fail?

The text was updated successfully, but these errors were encountered:

mruberry added the ci label

mruberry mentioned this issue

remove unused self_arg from thunder.dynamo.utils.is_node_supported_by_thunder #1546

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment