-
Notifications
You must be signed in to change notification settings - Fork 102
ci: test with latest dependencies #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bitsandbytes>=0.45.2,<0.45.5; sys_platform!='darwin'
just for mac
@t-vi, any insides what is happening? |
also on GPU: |
…/lightning-thunder into ci/test-with-latest
There is a race condition, I'm looking into fixing it, but I need to find the perf thing with it. |
cool, thank you |
bitsandbytes>=0.44,<0.45; sys_platform!='darwin' | ||
bitsandbytes>=0.42,<0.43; sys_platform=='darwin' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just relax it as a range 🐿️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't seem to be such package for ARM linux, any idea about this?
#37 8.827 ERROR: Could not find a version that satisfies the requirement bitsandbytes<0.45,>=0.44 (from versions: 0.31.8, 0.32.0, 0.32.1, 0.32.2, 0.32.3, 0.33.0, 0.33.1, 0.34.0, 0.35.0, 0.35.1, 0.35.2, 0.35.3, 0.35.4, 0.36.0, 0.36.0.post1, 0.36.0.post2, 0.37.0, 0.37.1, 0.37.2, 0.38.0, 0.38.0.post1, 0.38.0.post2, 0.38.1, 0.39.0, 0.39.1, 0.40.0, 0.40.0.post1, 0.40.0.post2, 0.40.0.post3, 0.40.0.post4, 0.40.1, 0.40.1.post1, 0.40.2, 0.41.0, 0.41.1, 0.41.2, 0.41.2.post1, 0.41.2.post2, 0.41.3, 0.41.3.post1, 0.41.3.post2, 0.42.0, 0.46.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @t-vi @jjsjann123
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird it was downloading
#37 7.810 Collecting bitsandbytes==0.42.0 (from -r requirements/test.txt (line 20))
#37 7.814 Downloading bitsandbytes-0.42.0-py3-none-any.whl.metadata (9.9 kB)
two days ago on ARM linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, apologies for breaking this for you.
I think we want "arm" not in platform_machine
and "arm" in platform_machine
as the conditions (cf. platform.machine() ). WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that sounds right
also maybe we can ask bitsandbytes
to compile also ARM packges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: #2257
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update on this: since bitsandbytes's release binaries usually aren't built with the latest cuda versions, we're now building BNB from source with the latest cuda versions internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to publish it to nvidia pypi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure because those are dev cuda versions before public release. It probably wouldn't work for you without the cuda library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Borda
Before submitting
What does this PR do?
This addresses now user's scenario who install the package on blank environment
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃