maple: fix wrong return value of maple_bus_init().

[ Upstream commit bde82ee391fa6d3ad054313c4aa7b726d32515ce ] If KMEM_CACHE or maple_alloc_dev failed, the maple_bus_init() will return 0 rather than error, because the retval is not changed after KMEM_CACHE or maple_alloc_dev failed. Fixes: 17be2d2 ("sh: Add maple bus support for the SEGA Dreamcast.") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Lu Wei <[email protected]> Acked-by: John Paul Adrian Glaubitz <[email protected]> Signed-off-by: Rich Felker <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
LineageOS · Nov 26, 2021 · ffd4333 · ffd4333
1 parent 88d87e0
commit ffd4333
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/drivers/sh/maple/maple.c b/drivers/sh/maple/maple.c
@@ -835,8 +835,10 @@ static int __init maple_bus_init(void)
 
 	maple_queue_cache = KMEM_CACHE(maple_buffer, SLAB_HWCACHE_ALIGN);
 
-	if (!maple_queue_cache)
+	if (!maple_queue_cache) {
+		retval = -ENOMEM;
 		goto cleanup_bothirqs;
+	}
 
 	INIT_LIST_HEAD(&maple_waitq);
 	INIT_LIST_HEAD(&maple_sentq);
@@ -849,6 +851,7 @@ static int __init maple_bus_init(void)
 		if (!mdev[i]) {
 			while (i-- > 0)
 				maple_free_dev(mdev[i]);
+			retval = -ENOMEM;
 			goto cleanup_cache;
 		}
 		baseunits[i] = mdev[i];