-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE_REQUEST] Base path option #1036
Comments
There is the environment option I tried (as explained in multiple tickets around here and somewhat in https://github.com/Lissy93/dashy/blob/master/docs/management.md#passing-in-environmental-variables) the following.
For a) I can connect to dashy, but fail to load any assets because the initial response wants to load js and css from / and hence does not get proxied. So, I would very much welcome an implementation of that feature :)
|
Same behavior here. Using docker compose with BASE_URL=/dashy. Browser returns error: "Cannot GET /dashy". |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Has this issue been fixed yet? |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment has been minimized.
This comment has been minimized.
This comment was marked as spam.
This comment was marked as spam.
There is an example in the documentation here that tells you to use However, this does not work. When I load the latest version (3.1.1), I get this error in my browser console: It should be pointing to https://example.com/dashy/conf.yml since this is where the assets should be. In fact, if I navigate to https://example.com/dashy/conf.yml, I can actually see my config! This seems like it should be a straightforward issue to fix, and I would consider it high priority since there is an example in your documentation. I also see the same behavior for |
Is your feature request related to a problem? If so, please describe.
No response
Describe the solution you'd like
BasePath or similar option for when behind a reverse proxy.
I can run it fine by directly accessing the IP address, eg: 123.123.123.123:4000, but if this is placed behind a reverse proxy with a subpath Dashy doesn't load at all.
The reason is due to absolute pathing when loading assets.
Lets say Dashy is hosted at
mydomain.com/dashy
, all requests will go tomydomain.com/
. For example when requesting themanifest.json
file, I can see it tries to request frommydomain.com/manifest.json
instead ofmydomain.com/dashy/manifest.json
.Adding in a BasePath or relative pathing config option, will allow for letting Dashy know that it should be requesting from a subdirectory.
I quickly checked the Config docs, but couldn't see anything relevant: https://github.com/Lissy93/dashy/blob/master/docs/configuring.md
I would imagine this would fall under the appConfig section.
Reopened since #923 was automatically closed.
Priority
Medium (Would be very useful)
Is this something you would be keen to implement
Yes!
The text was updated successfully, but these errors were encountered: