Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add missing 16x16 favicon and fix 32x32 and 64x64 favicon resolution #1678

Merged
merged 2 commits into from
Aug 23, 2024
Merged

[FIX] Add missing 16x16 favicon and fix 32x32 and 64x64 favicon resolution #1678

merged 2 commits into from
Aug 23, 2024

Conversation

m42cel
Copy link
Contributor

@m42cel m42cel commented Aug 23, 2024 •
edited by pull-request-badge bot
Loading

m42cel Quick m42cel /master → Lissy93/dashy Commits: 2 | Files Changed: 5 | Additions: 2 Label Powered by Pull Request Badge

Category:
Bugfix

Overview
Add 16x16 favicon and fix resolution of 32x32 and 64x64 favicons (was 33x32 and 65x64)

Issue Number
#1588

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors

@m42cel m42cel requested a review from Lissy93 as a code owner August 23, 2024 09:17
@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit e22ae28
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/66c853952bd3dd0008ef932f
😎 Deploy Preview https://deploy-preview-1678--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Lissy93
Lissy93 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lissy93 Lissy93 merged commit 0bb22d0 into Lissy93:master Aug 23, 2024
8 checks passed
@CrazyWolf13 CrazyWolf13 mentioned this pull request Aug 24, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m42cel @Lissy93