Consider removing the EqualsOrdinalIgnoreCase extension method (OSOE-915)

[sarahelsaig]

In get this error in OrchardCore 2.0 too often:

TestApiController.cs(105, 62): [CS0121] The call is ambiguous between the following methods or properties: 'System.StringExtensions.EqualsOrdinalIgnoreCase(string, string?)' and 'OrchardCore.Modules.StringExtensions.EqualsOrdinalIgnoreCase(string?, string?)'

This is because the extension method in OC here.

Jira issue

[Piedone]

Our extensions are in the System namespace, so accessible without further ado if you use string. The OC ones are in OrchardCore.Modules, so less easily discoverable.

So, I'd prefer have ours, or change the namespace in OC.

Can you link a few samples where you had this clash?

[sarahelsaig]

I don't commit build errors into git so I can't link samples. I think the most common example is if you are in a service that injects IClock, ILocalClock or IApplicationContext then you can't use our extension method because those interfaces live in the same namespace as OC's extension class. Also if you want to use EqualsOrdinalIgnoreCase and ContainsOrdinalIgnoreCase in a service that injects any of the above services, you can't. (technically you can, if you always use the fully qualified namespace for the services instead of using OrchardCore.Modules, but then you'll have to fight with the IDE forever)

[Piedone]

I think the solution here is to change the namespace in OC.

[sarahelsaig]

Try to push through an upstream breaking change? 😱 I'll let you fight that windmill if you want.

[Piedone]

It is breaking, but I doubt many would notice :). Nevertheless should be v3. In any case, I don't think we should change HL.

[Piedone]

Hmm. Just when I wanted to open an OC issue, I realized that a further problem is that this extensions class is in Lombiq.HelpfulLibraries.Common, i.e. it may be (and is) used in non-OC projects. Thus, we shouldn't remove it even if the OC class is moved.

While this is far from ideal, I think what remains is indeed fully qualifying the service injections.