Skip to content

SX126x : Missing security on casting symbTimeout in RadioSetRxConfig #1637

@Martdur

Description

@Martdur

Observation

In RadioSetRxConfig there is no security on casting uint16_t symbTimeout to uint_8t in SX126xSetLoRaSymbNumTimeout.

Impact

Leading to Rx2 timeout issues due to wrong Rx window value.

symbTimeout should be lower than uint8_t limitation otherwise it'll trigger wrong timeout irq.

This can happens when using high data rate with a high MAX_RX_TIMEOUT_ERROR.

Recommendation

Add a security in the choice of MAX_RX_TIMEOUT_ERROR or in the definition of Rxearly Rxlate and RxWindowTimeout.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions