Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Update #5

Open
LuckyDucko opened this issue Mar 11, 2020 · 2 comments
Open

Documentation Update #5

LuckyDucko opened this issue Mar 11, 2020 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@LuckyDucko
Copy link
Owner

There is a lot of auto documentation that needs to be added to make the codebase easier to navigate and work with. this is here to hold me to it.

@LuckyDucko LuckyDucko added the documentation Improvements or additions to documentation label Mar 11, 2020
@LuckyDucko LuckyDucko self-assigned this Mar 11, 2020
@jon085
Copy link

jon085 commented Feb 5, 2021

WrapReturnableTaskInLoader Doesn't seem to work.
The example doesn't seem to work correctly.

@LuckyDucko
Copy link
Owner Author

LuckyDucko commented Feb 7, 2021

Hey @jon085 sorry for late reply.

Does the sample work correctly for you? The documentation hasn't been updated for a bit so thank you for letting me know


Edit: I just realised what the issue was, I have made an update to WrapReturnableTaskInLoader to allow for people to include their own version of the loaderpopuppage which they can customise themselves.

The example has also been updated, not documentation, to avoid a pitfall I had with loaders that overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants