Fix linter issues

Author: Mystilund

.eslintrc.js

@@ -10,7 +10,8 @@ module.exports = {
     mocha: true
   },
   rules: {
-    'arrow-parens': 0
+    'arrow-parens': 0,
+    'node/no-deprecated-api': 0
   },
   globals: {
     __root: true,

config/build.js

@@ -2,11 +2,11 @@ const fs = require('fs')
 const path = require('path')
 const { exec } = require('child_process')
 
-let rawdata = fs.readFileSync(path.join(__dirname, '../package.json'))
-let packageJson = JSON.parse(rawdata)
+const rawdata = fs.readFileSync(path.join(__dirname, '../package.json'))
+const packageJson = JSON.parse(rawdata)
 
 if (typeof packageJson['build-config'] !== 'undefined' && typeof packageJson['build-config'].exportAliases !== 'undefined') {
-  for (let filename in packageJson['build-config'].exportAliases) {
+  for (const filename in packageJson['build-config'].exportAliases) {
     exec(`cp -rf ${path.join(__dirname, '../', packageJson['build-config'].exportAliases[filename])} ${path.join(__dirname, '../', filename)}`)
   }
 }

examples/02-multiple-response-type/main.js

@@ -1,6 +1,6 @@
 const routes = require('./routes')
 const Cherry = require('../../src/cherry')
-const CherryHandlebarsConnector = require('@lund-org/cherry-handlebars-connector')
+// const CherryHandlebarsConnector = require('@lund-org/cherry-handlebars-connector')
 const CherryPugConnector = require('@lund-org/cherry-pug-connector')
 
 const options = {
@@ -10,7 +10,7 @@ const options = {
     }
   ],
   plugins: [
-    /*CherryHandlebarsConnector,*/
+    // CherryHandlebarsConnector,
     CherryPugConnector
   ],
   routes

examples/02-multiple-response-type/routes.js

@@ -37,7 +37,7 @@ module.exports = {
       method: ['GET'],
       path: '/json-object',
       callback: (req, res) => {
-        let obj = {
+        const obj = {
           key: 'value'
         }
         obj.circular = obj

examples/04-orm/main.js

@@ -39,7 +39,7 @@ const options = {
       port: 4005
     }
   ],
-  plugins: [ CherrySequelizeConnector, CherryTypeormConnector ],
+  plugins: [CherrySequelizeConnector, CherryTypeormConnector],
   routes,
   database: typeormConfig
   // database: sequelizeConfig

examples/04-orm/typeorm/models/Model.js

@@ -1,7 +1,7 @@
 module.exports = class Model {
   set (data) {
     if (typeof data !== 'undefined') {
-      for (let index in data) {
+      for (const index in data) {
         if (typeof this[index] !== 'undefined') {
           this[index] = data[index]
         }

src/abstract/CherryRouteManager.js

@@ -16,7 +16,7 @@ class CherryRouteManager {
 
     for (const Router of routers) {
       if (Router.getType() === routeConfig.type) {
-        let router = new Router(routeConfig)
+        const router = new Router(routeConfig)
 
         this.routes = this.routes.concat(router.build())
         routeTypeMatch = true

src/builtins/response.js

@@ -152,7 +152,7 @@ function json (ref, refOptions = null) {
  */
 function redirect (redirectUri, redirectionCode = 301) {
   const headers = {
-    'Location': redirectUri
+    Location: redirectUri
   }
   response.call(this, redirectionCode, headers, '')
 }

src/configuration/PluginConfigurator.js

@@ -33,7 +33,7 @@ class PluginConfigurator extends CherryConfigurator {
    * @return {mixed}
    */
   getPluginInstance (name) {
-    let PluginClass = this.getPlugin(name)
+    const PluginClass = this.getPlugin(name)
 
     if (typeof PluginClass !== 'undefined' && PluginClass) {
       return new PluginClass()

src/configuration/RouteConfigurator.js

@@ -106,7 +106,7 @@ class RouteConfigurator extends CherryConfigurator {
     let routeResponse = null
 
     manager.getRoutes().some((publicRoute) => {
-      let tmp = publicRoute.matchRoute(route, req, res)
+      const tmp = publicRoute.matchRoute(route, req, res)
 
       if (tmp.getMatchingRoute()) {
         routeResponse = tmp