Errors shown when clicking on Settings button in the left menu after session timeout

[sancsin]

Lychee version

v6.2.0

Which PHP version are you using?

PHP 8.4

Detailed description of the problem

Unexpected behaviour

Errors are shown when clicking on Settings button in the left menu from any other view of the left menu, such as Users view. The errors are shown when session has timed out. The type of errors shown are provided in the screenshot below.

Expected behaviour

No errors should be shown when clicking on Settings button in the left menu. Ideally, the user should be redirected to the main gallery page after informing the user that the session has timed out

Steps to reproduce the issue

1. Change the SESSION_LIFETIME value in .env file to something very small, such as 1 to reproduce the issue faster
2. Login to your Lychee website
3. Open Users view by clicking on Users button from the left menu without closing the left menu
4. Wait for session to expire
5. Click on Settings button in the left menu
6. Observe the errors

Diagnostics [REQUIRED]

Lychee Version (git): master (dde9b5a) -- Up to date (7 hours ago).
DB Version: 6.2.0
composer install: --no-dev
APP_ENV: production
APP_DEBUG: false
APP_URL: set
APP_DIR: default
LOG_VIEWER_ENABLED: true
VUEJS_ENABLED: true
PHOTO_PIPES: true
System: Linux
PHP Version: 8.3.6
PHP User agent: Lychee/4 (https://lycheeorg.github.io/)
Timezone: Europe/Stockholm
Max uploaded file size: 10000M
Max post size: 10000M
Chunk size: 12.80 MB
Max execution time: 1000
SQLite Version: 3.45.1
exec() Available: yes
Imagick Available: 1
Imagick Enabled: 1
Imagick Version: 1692
GD Version: 2.3.3
Number of foreign key: 11 found.

Browser & System [REQUIRED]

System

Operating System: Manjaro Linux
KDE Plasma Version: 6.2.4
KDE Frameworks Version: 6.8.0
Qt Version: 6.8.1
Kernel Version: 6.6.65-1-MANJARO (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-9700K CPU @ 3.60GHz
Memory: 31.3 GiB of RAM
Graphics Processor: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2

Browser

Google Chrome Version 131.0.6778.204 (Official Build) (64-bit)

Please confirm (incomplete submissions will not be addressed)

• I have provided easy and step-by-step instructions to reproduce the bug.
• I understand my bug report will be removed if I haven't met the criteria above.

[ildyria]

I don't think those two errors are related to the session. Because those are Ajax calls to the files in public/dist which are directly accessible, there is literally no guard on those. I guess you are missing the said files.

[sancsin]

I have a fix for the timeout, exactly in axios configuration as you propose (for the frontend part at least) Will upload it tomorrow. Hope you can review and propose improvements.

[ildyria]

This needs to be done on the front-end side indeed. There is nothing that can be done in the background.
It is 2:23 am here, fixing a small thing on the front-end for duplicate finding and then sleep :)

[sancsin]

I don't think those two errors are related to the session. Because those are Ajax calls to the files in public/dist which are directly accessible, there is literally no guard on those. I guess you are missing the said files.

Hmm. But I don't get those errors when the session is not timed out. So I believe those errors are somehow related to session being timed out and that the user is not logged in anymore and therefore should not be able to open the Settings view.

[ildyria]

Then that is very weird, see here:
https://github.com/LycheeOrg/Lychee/blob/master/resources/js/services/settings-service.ts#L24
https://github.com/LycheeOrg/Lychee/blob/master/resources/js/components/settings/EasySettings.vue#L390

[sancsin]

This needs to be done on the front-end side indeed. There is nothing that can be done in the background.

It is 2:23 am here, fixing a small thing on the front-end for duplicate finding and then sleep :)

Tried the duplicate feature today. Works great and a very value adding feature for this wonderful photo management webapp.

[sancsin]

PR #2898 fixes this issue. So closing this discussion.