Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculateBatteryDischarge is probably incomplete #24

Open
UltimateSteve99 opened this issue Oct 8, 2022 · 0 comments
Open

calculateBatteryDischarge is probably incomplete #24

UltimateSteve99 opened this issue Oct 8, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@UltimateSteve99
Copy link
Contributor

In BatteryCapacity.h, the calculateBatteryDischarge function only reads voltage and current from the battery bus, ignoring the 5v and 3.3v buses. It is possible that I misread it and everything goes through the battery bus, the diagrams aren't super clear on that, but I think the other buses need to be taken into account (unless, of course, nothing is hooked up to them). Fixing this requires adding more values to the BatteryMeasurement struct (which I am working on right now).

@UltimateSteve99 UltimateSteve99 added the bug Something isn't working label Oct 8, 2022
@UltimateSteve99 UltimateSteve99 self-assigned this Oct 8, 2022
@hcshires hcshires added this to the Satellite Beacon milestone Oct 16, 2022
@hcshires hcshires removed this from the Cy-Sat 1 Transmit & Receive milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants